Alternate pvp objective#2760
Open
DeltaFire15 wants to merge 5 commits into
Open
Conversation
DeltaFire15
added
Feature
Code Improvement
Fix
Overmap
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
This will conflict to hell with my refactor so not updating it for the moment. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR adds an alternate objective / goal to the pvp gamemode. Currently implemented by replacing base pvp's, until it is decided whether this is to be a replacement / option / whatever else.
This should not be fullmerged before that is decided.
This new mission leads both vessels to a specific system with a Wormhole Anchor station, where the Syndicate is attempting to stabilize a wormhole into Sol.
Being in this system without the other ship being present for 15 minutes (not neccessarily in a row) leads to victory.
The (automated) anchor station itself cannot be destroyed. By default, it will will fire upon any vessels in system, however getting a lead of at least 3 minutes compared to the other side flips control of it to you.
There is a grace period of 25 minutes between game start and any control starting to lead to timer decrease, as to leave a bit of leeway. Additionally, every 5 minutes of control (or the station having its allegiance overridden) cause an announcement to keep progress obvious (albeit it can also be seen on the comms console).
Of course, as always, simply blowing up the other ship works too.
Aand of course this also fixes / tweaks bits of code, because there's always more to fix.
Why It's Good For The Game
The current pvp objective doesn't really do anything that encourages the mode being "pvp", since nothing you need to do leads to immediate conflict unless you happen to run across eachother.
This is a more focused take that should cause some more direct confrontation.
Testing Photographs and Procedure
I've done basic testing, however as always things may get past me.
Changelog
🆑
add: New pvp objective. Fight for a system where the syndicate is attempting to create a wormhole to Sol.
code: Makes the overmap objective defines not just usable in that single file because that is painful.
code: Moves a bit of roundend nsv change code into an nsv folder so it can use nsv defines.
fix: Overmap gamesmodes no longer do some very evil things (not calling parent on new, for one).
/:cl: