Improve error handling for Discord OAuth#35
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Improves Discord OAuth error handling by replacing broad exception catches with specific ones, adding distinct error messages, and introducing a default session duration when the config value is missing.
- Refactored imports to alias
Clientand bring in exception types - Expanded exception handling with differentiated responses and logging
- Added fallback for missing
game-session-durationand updated template rendering
Comments suppressed due to low confidence (2)
src/bapi/blueprints/discord.py:8
- [nitpick] Consider importing the exceptions module using lowercase (e.g.
import discordoauth2.exceptions as exceptions) or importing specific exception classes instead of aliasing everything underExceptionsto follow PEP8 and improve clarity.
from discordoauth2.exceptions import Exceptions
src/bapi/blueprints/discord.py:84
- There are several new exception handling branches (e.g.,
RateLimited,Forbidden,HTTPException,KeyError) that should have corresponding unit tests to verify the correct status codes and error messages are returned.
except Exceptions.Forbidden:
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 500 Internal Server Error from bad imports and provides much more useful and distinguished error messages, while not disclosing too much information to the user.
Also handles a missing session duration and uses the default value.