Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Symfony 5 compatiblity#360

Closed
cdaguerre wants to merge 1 commit into
Behat:masterfrom
cdaguerre:sf-5-compat
Closed

Symfony 5 compatiblity#360
cdaguerre wants to merge 1 commit into
Behat:masterfrom
cdaguerre:sf-5-compat

Conversation

@cdaguerre

@cdaguerre cdaguerre commented Mar 17, 2020

Copy link
Copy Markdown

No description provided.

@cdaguerre cdaguerre force-pushed the sf-5-compat branch 2 times, most recently from 0523e65 to 112ce26 Compare March 17, 2020 12:17
@chadyred chadyred mentioned this pull request Mar 18, 2020
Closed
@chadyred

chadyred commented Mar 18, 2020

Copy link
Copy Markdown

Works as expected, thanks but their is another existing PR but yours seems more complete than #355

@chadyred

chadyred commented Mar 18, 2020 •
edited
Loading

Copy link
Copy Markdown

@stof Is it possible to take a look at this, simple to review ? Many PR pop for this small change.

@DerMonozukurist

DerMonozukurist commented Apr 3, 2020

Copy link
Copy Markdown

Reached out to @stof, @everzet, and @ciaranmcnulty in Twitter - it could be possible that they're very busy with more important stuff.

@Guikingone

Guikingone commented Apr 28, 2020

Copy link
Copy Markdown

Hi everyone 👋

Any news about this PR? 🤔

@DerMonozukurist

DerMonozukurist commented Apr 28, 2020

Copy link
Copy Markdown

Hi everyone wave

Any news about this PR?

Here's the workaround I use atm:

"require-dev": {
    "behat/mink-extension": "dev-upgrade/allow-symony-5 as 2.3"
},
"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/chadyred/MinkExtension"
    }
]

@chadyred

chadyred commented Apr 30, 2020

Copy link
Copy Markdown

We waiting for it ;)

@I-Valchev

I-Valchev commented May 20, 2020

Copy link
Copy Markdown

Any updates yet?

@pamil

pamil commented May 20, 2020

Copy link
Copy Markdown
Member

This extension will be moved to @FriendsOfBehat organization soon. Please use friends-of-behat/mink-extension instead of behat/mink-extension, no need to change anything in the code except for this dependency.

DonCallisto added a commit to DonCallisto/BehatPageObjectExtension that referenced this pull request Jun 18, 2020
@DonCallisto
Replaced behat/mink-extension in favor of friends-of-behat/mink-exten…
67ee59c 
…sion

As per Behat/MinkExtension#360 (comment)
@DonCallisto DonCallisto mentioned this pull request Jun 18, 2020
Merged
jakzal added a commit to jakzal/BehatPageObjectExtension that referenced this pull request Jun 18, 2020
@jakzal
Replaced behat/mink-extension in favor of friends-of-behat/mink-exten…
bb030fe 
…sion

As per Behat/MinkExtension#360 (comment)
robertfausk added a commit to robertfausk/behat-panther-extension that referenced this pull request Sep 21, 2020
@robertfausk
Add support for symfony 5 with symfony/config ...|^5.0
40354e2 
by using branch of
as described in Behat/MinkExtension#360
robertfausk added a commit to robertfausk/behat-panther-extension that referenced this pull request Sep 21, 2020
@robertfausk
Add support for symfony 5 with symfony/config ...|^5.0
db055d2 
by using branch of
as described in Behat/MinkExtension#360

(cherry picked from commit 40354e2)
robertfausk added a commit to robertfausk/behat-panther-extension that referenced this pull request Sep 21, 2020
@robertfausk
Use friends-of-behat/mink-extension:^2.3.0 instead of deprecated/aban…
a05c49d 
…doned behat/mink-extension

also see:
Behat/MinkExtension#360 (comment)
@thbil thbil mentioned this pull request Oct 16, 2020
Closed
@cdaguerre cdaguerre closed this Apr 12, 2021
@xurizaemon

xurizaemon commented Apr 20, 2022 •
edited
Loading

Copy link
Copy Markdown

@pamil @everzet given #360 (comment), should Behat/MinkExtension now be marked abandoned in Packagist, in favour of friends-of-behat/mink-extension?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@chadyred chadyred chadyred approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cdaguerre @chadyred @DerMonozukurist @Guikingone @I-Valchev @pamil @xurizaemon