Fix clang-tidy readability-implicit-bool-conversion warning

facontidavide · claude · facontidavide · commit 9264196fdb7b · 2026-02-01T20:29:18.000+01:00
Use explicit != nullptr comparison for pointer-to-bool conversion
flagged by clang-tidy.

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/src/tree_node.cpp b/src/tree_node.cpp
@@ -481,7 +481,7 @@ AnyPtrLocked BT::TreeNode::getLockedPortContent(const std::string& key)
   {
     const auto bb_key = std::string(*remapped_key);
     auto result = _p->config.blackboard->getAnyLocked(bb_key);
-    if(!result && _p->config.manifest)
+    if(!result && _p->config.manifest != nullptr)
     {
       // Entry doesn't exist yet. Create it using the port's type info
       // from the manifest so that getLockedPortContent works even when

Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,7 @@ AnyPtrLocked BT::TreeNode::getLockedPortContent(const std::string& key)`
`481`	`481`	`{`
`482`	`482`	`const auto bb_key = std::string(*remapped_key);`
`483`	`483`	`auto result = _p->config.blackboard->getAnyLocked(bb_key);`
`484`		`- if(!result && _p->config.manifest)`
	`484`	`+ if(!result && _p->config.manifest != nullptr)`
`485`	`485`	`{`
`486`	`486`	`// Entry doesn't exist yet. Create it using the port's type info`
`487`	`487`	`// from the manifest so that getLockedPortContent works even when`