Fix CI failures: TSAN race, clang-tidy, and nodiscard warnings

- Fix TSAN race condition in FileLogger2: set ready flag AFTER acquiring
  mutex for the first time to establish proper synchronization
- Add deleted copy operations to FileLogger2PImplBase to satisfy
  cppcoreguidelines-special-member-functions
- Fix nodiscard warnings in tests by casting convertFromString return
  values to void in ASSERT_THROW statements

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: facontidavide

.gitignore

@@ -26,3 +26,4 @@ t11_groot_howto.btlog
 minitrace.json
 /.worktrees/*
 /docs/plans/*
+/coverage_report/*

include/behaviortree_cpp/loggers/bt_file_logger_v2.h

@@ -22,6 +22,8 @@ struct FileLogger2PImplBase
   std::unique_ptr<FileLogger2Private> _p;
   FileLogger2PImplBase();
   ~FileLogger2PImplBase();
+  FileLogger2PImplBase(const FileLogger2PImplBase&) = delete;
+  FileLogger2PImplBase& operator=(const FileLogger2PImplBase&) = delete;
   FileLogger2PImplBase(FileLogger2PImplBase&&) = default;
   FileLogger2PImplBase& operator=(FileLogger2PImplBase&&) = default;
 };

src/loggers/bt_file_logger_v2.cpp

@@ -132,12 +132,17 @@ void FileLogger2::flush()
 
 void FileLogger2::writerLoop()
 {
-  // Signal that the writer thread is ready to accept callbacks
-  _p->ready.store(true, std::memory_order_release);
-
   // local buffer in this thread
   std::deque<Transition> transitions;
 
+  // Signal that the writer thread is ready to accept callbacks.
+  // IMPORTANT: This must happen AFTER acquiring the mutex for the first time,
+  // to establish proper synchronization with the callback thread.
+  {
+    std::scoped_lock lock(_p->queue_mutex);
+    _p->ready.store(true, std::memory_order_release);
+  }
+
   while(_p->loop)
   {
     transitions.clear();

tests/gtest_basic_types.cpp

@@ -97,8 +97,8 @@ TEST(BasicTypes, ConvertFromString_Int)
   ASSERT_EQ(convertFromString<int>("-42"), -42);
   ASSERT_EQ(convertFromString<int>("0"), 0);
 
-  ASSERT_THROW(convertFromString<int>("not_a_number"), RuntimeError);
-  ASSERT_THROW(convertFromString<int>(""), RuntimeError);
+  ASSERT_THROW((void)convertFromString<int>("not_a_number"), RuntimeError);
+  ASSERT_THROW((void)convertFromString<int>(""), RuntimeError);
 }
 
 TEST(BasicTypes, ConvertFromString_Int64)
@@ -120,7 +120,7 @@ TEST(BasicTypes, ConvertFromString_Double)
   ASSERT_DOUBLE_EQ(convertFromString<double>("0.0"), 0.0);
 
   // Invalid double throws std::invalid_argument
-  ASSERT_THROW(convertFromString<double>("not_a_number"), std::invalid_argument);
+  ASSERT_THROW((void)convertFromString<double>("not_a_number"), std::invalid_argument);
 }
 
 TEST(BasicTypes, ConvertFromString_Bool)
@@ -135,7 +135,7 @@ TEST(BasicTypes, ConvertFromString_Bool)
   ASSERT_FALSE(convertFromString<bool>("FALSE"));
   ASSERT_FALSE(convertFromString<bool>("0"));
 
-  ASSERT_THROW(convertFromString<bool>("invalid"), RuntimeError);
+  ASSERT_THROW((void)convertFromString<bool>("invalid"), RuntimeError);
 }
 
 TEST(BasicTypes, ConvertFromString_String)
@@ -153,7 +153,7 @@ TEST(BasicTypes, ConvertFromString_NodeStatus)
   ASSERT_EQ(convertFromString<NodeStatus>("IDLE"), NodeStatus::IDLE);
   ASSERT_EQ(convertFromString<NodeStatus>("SKIPPED"), NodeStatus::SKIPPED);
 
-  ASSERT_THROW(convertFromString<NodeStatus>("INVALID"), RuntimeError);
+  ASSERT_THROW((void)convertFromString<NodeStatus>("INVALID"), RuntimeError);
 }
 
 TEST(BasicTypes, ConvertFromString_NodeType)