Skip to content

Commit a590e6a

Browse files
facontidavideclaude
andcommitted
Add Debug build to Windows CI matrix
The Windows workflow only tested Release builds, leaving Debug-mode fixes (like #869 TINYXML2_DEBUG crash and #836 MSVC runtime linkage) unverified. Add build_type matrix dimension to test both Release and Debug configurations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent e2460ae commit a590e6a

1 file changed

Lines changed: 6 additions & 15 deletions

File tree

.github/workflows/cmake_windows.yml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,13 @@ on:
77
pull_request:
88
types: [opened, synchronize, reopened]
99

10-
env:
11-
# Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
12-
BUILD_TYPE: Release
13-
1410
jobs:
1511
build:
16-
# The CMake configure and build commands are platform agnostic and should work equally
17-
# well on Windows or Mac. You can convert this to a matrix build if you need
18-
# cross-platform coverage.
19-
# See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
2012
runs-on: ${{ matrix.os }}
2113
strategy:
2214
matrix:
2315
os: [windows-latest]
16+
build_type: [Release, Debug]
2417

2518
steps:
2619
- uses: actions/checkout@v6
@@ -33,13 +26,11 @@ jobs:
3326
run: conan profile detect
3427

3528
- name: Install conan dependencies
36-
run: conan install conanfile.py -s build_type=${{env.BUILD_TYPE}} --build=missing --settings:host compiler.cppstd=17
29+
run: conan install conanfile.py -s build_type=${{ matrix.build_type }} --build=missing --settings:host compiler.cppstd=17
3730

3831
- name: Normalize build type
3932
shell: bash
40-
# The build type is Capitalized, e.g. Release, but the preset is all lowercase, e.g. release.
41-
# There is no built in way to do string manipulations on GHA as far as I know.`
42-
run: echo "BUILD_TYPE_LOWERCASE=$(echo "${BUILD_TYPE}" | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV
33+
run: echo "BUILD_TYPE_LOWERCASE=$(echo "${{ matrix.build_type }}" | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV
4334

4435
- name: Configure CMake
4536
shell: bash
@@ -49,6 +40,6 @@ jobs:
4940
shell: bash
5041
run: cmake --build --preset conan-${{ env.BUILD_TYPE_LOWERCASE }}
5142

52-
- name: run test (Windows)
53-
working-directory: ${{github.workspace}}/build
54-
run: $env:PATH+=";${{env.BUILD_TYPE}}"; tests/${{env.BUILD_TYPE}}/behaviortree_cpp_test.exe
43+
- name: Run tests
44+
working-directory: ${{ github.workspace }}/build
45+
run: $env:PATH+=";${{ matrix.build_type }}"; tests/${{ matrix.build_type }}/behaviortree_cpp_test.exe

0 commit comments

Comments
 (0)