miscellaneus

Author: facontidavide

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/pre-commit.yaml

@@ -11,14 +11,14 @@ jobs:
   pre-commit:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-python@v3
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
     - uses: pre-commit/action@v3.0.1
 
   clang-tidy:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - name: Install LLVM 21
       run: |

include/behaviortree_cpp/utils/simple_string.hpp

@@ -52,8 +52,6 @@ class SimpleString
   {
     if(this != &other)
     {
-      this->~SimpleString();
-      _storage = {};
       std::swap(_storage, other._storage);
     }
     return *this;

run_clang_tidy.sh

@@ -14,7 +14,7 @@ if ! command -v clangd-21 &> /dev/null; then
   echo "  wget https://apt.llvm.org/llvm.sh"
   echo "  chmod +x llvm.sh"
   echo "  sudo ./llvm.sh 21"
-  echo "  sudo apt install clangd-21 clangd-tidy-21"
+  echo "  sudo apt install clangd-21 clang-tidy-21"
   exit 1
 fi
 
@@ -59,7 +59,7 @@ for path in "${skip_list[@]}"; do
 done
 echo "-----------------------------------------------------------"
 
-find $clang_tidy_paths \( -name '*.cpp' -o -name '*.hpp' -o -name '*.h' \) -not -name '*_WIN.cpp' "${skip_paths[@]}" -print0 \
+find "$ws_dir/src" "$ws_dir/include" \( -name '*.cpp' -o -name '*.hpp' -o -name '*.h' \) -not -name '*_WIN.cpp' "${skip_paths[@]}" -print0 \
   | xargs -0 -n 1 -P $(nproc) bash -c '
     set -o pipefail
     echo "$@"

src/basic_types.cpp

@@ -52,11 +52,11 @@ std::string toStr(NodeStatus status, bool colored)
     case NodeStatus::SUCCESS:
       return "\x1b[32m"
              "SUCCESS"
-             "\x1b[0m";  // RED
+             "\x1b[0m";  // GREEN
     case NodeStatus::FAILURE:
       return "\x1b[31m"
              "FAILURE"
-             "\x1b[0m";  // GREEN
+             "\x1b[0m";  // RED
     case NodeStatus::RUNNING:
       return "\x1b[33m"
              "RUNNING"

src/controls/reactive_fallback.cpp

@@ -53,7 +53,7 @@ NodeStatus ReactiveFallback::tick()
         }
         if(running_child_ == -1)
         {
-          running_child_ = int(index);
+          running_child_ = static_cast<int>(index);
         }
         else if(throw_if_multiple_running && running_child_ != static_cast<int>(index))
         {

src/xml_parsing.cpp

@@ -690,11 +690,11 @@ TreeNode::Ptr XMLParser::PImpl::createNodeFromXML(const XMLElement* element,
         else
         {
           const auto& port_model = port_model_it->second;
-          const bool is_blacbkboard = port_value.size() >= 3 &&
-                                      port_value.front() == '{' &&
-                                      port_value.back() == '}';
+          const bool is_blackboard = port_value.size() >= 3 &&
+                                     port_value.front() == '{' &&
+                                     port_value.back() == '}';
           // let's test already if conversion is possible
-          if(!is_blacbkboard && port_model.converter() && port_model.isStronglyTyped())
+          if(!is_blackboard && port_model.converter() && port_model.isStronglyTyped())
           {
             // This may throw
             try