CMake: prefer system tinyxml2

[nim65s]

Hi,

Here is a simple fix for #1014.

[facontidavide]

Broken CI

[facontidavide]

please check this commit:
c381486

[nim65s]

That looks great, thanks !

[facontidavide]

Do we want to set USE_VENDORED_TINYXML2 by default when compiling in ROS2?

[nim65s]

From a downstream distribution point of view, I would say generally vendoring should be avoided to ensure the cohesion of the entire software distribution, ease upgrading, avoid security issues, and consume less resources.

[facontidavide]

developing a library for multiple operative systems, build systems (colcon, cmake, piki, vanilla cmake, etc) is challenging.

Yes, I am guilty of vendoring libraries...

For the records, I tried hard to make these private and not public dependencies, that is extra work too.

[nim65s]

I know the challenges and I blame you for nothing. Quite the contrary, I'm just here to thank you for the software, and to provide assistance on the packaging side, if needed.

(This is actually my work, and I love it 😅)

Making the dependencies private is a great move that few project do, thanks for that too !