Skip to content

Fix #1065: type conversion for subtree string remapping#1072

Merged
facontidavide merged 1 commit intomasterfrom
fix/issue-1065
Feb 1, 2026
Merged

Fix #1065: type conversion for subtree string remapping#1072
facontidavide merged 1 commit intomasterfrom
fix/issue-1065

Conversation

@facontidavide
Copy link
Copy Markdown
Collaborator

Summary

  • Fix std::runtime_error when passing typed data (e.g. std::deque) through SubTree ports via string literals
  • Upgrade weakly-typed blackboard entries when a strongly-typed port connects

Test plan

  • New test: PortTest.SubtreeStringRemapping_Issue1065
  • All existing tests pass (298/298)

Closes #1065

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 1, 2026

Warning

Rate limit exceeded

@facontidavide has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/issue-1065

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The string value passed through a SubTree port is already type-erased
(AnyTypeAllowed) per the port connection rules, and LoopNode's runtime
string conversion handles the rest. This test verifies the behavior.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@facontidavide facontidavide merged commit 2d81a59 into master Feb 1, 2026
12 checks passed
@facontidavide facontidavide deleted the fix/issue-1065 branch February 1, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type conversion problem with subtree

1 participant