[CI proof — do not merge] option-row height fix (upstream #11264)#597
Open
BenJule wants to merge 1 commit into
Open
[CI proof — do not merge] option-row height fix (upstream #11264)#597BenJule wants to merge 1 commit into
BenJule wants to merge 1 commit into
Conversation
init_ctrl_lines() reserved the option-row height with a '(label width > column ? 2 : 1)' heuristic that caps a wrapped label at two lines. CtrlLine::render, however, wraps the label with Label::split_lines (unlimited lines) and vertically centers it inside the row height, so a label that wraps to three or more lines (common with longer translations) overflowed and was drawn on top of the next option row. Reserve the actual wrapped height using the same helper and width that the renderer uses, plus the existing vertical gap. Single- and two-line rows are unaffected.
github-actions
Bot
added
area: ci
github-actions
Bot
added
area: ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI evidence only — do not merge. This re-runs the exact change from upstream PR bambulab#11264 (the option-row height fix for wrapped multi-line labels) through this fork's working CI, since upstream CI is currently red for the known
windows-latest/VS 2026 + macOS-SDK infra issues. The green run here demonstrates the change compiles on all platforms. (Visual verification of the label overlap is still separate.)