Skip to content

Commit 06c3fde

Browse files
skip field, use recursive_find
1 parent 56f0883 commit 06c3fde

3 files changed

Lines changed: 4 additions & 100 deletions

File tree

src/allotropy/parsers/biorad_bioplex_manager/biorad_bioplex_manager_structure.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ def create(well_xml: StrictXmlElement) -> Well:
148148
sample_volume_element.get_text("SampleVolume"),
149149
"sample_volume",
150150
),
151-
detector_gain_setting=well_xml.find("RunConditions")
152-
.find("RP1Gain")
153-
.get_text("RP1Gain"),
151+
detector_gain_setting=well_xml.recursive_find(
152+
["RunConditions", "RP1Gain"]
153+
).get_text("RP1Gain"),
154154
minimum_assay_bead_count_setting=try_int(
155155
stop_reading_criteria_element.get_attr("BeadCount"),
156156
"minimum_assay_bead_count_settings",
@@ -165,7 +165,7 @@ def create(well_xml: StrictXmlElement) -> Well:
165165
analyst=well_xml.find("User").get_text("User"),
166166
xml=well_xml.element,
167167
custom_info={
168-
**well_xml.get_unread(),
168+
**well_xml.get_unread(skip={"WellNo"}),
169169
**sample_volume_element.get_unread(),
170170
**stop_reading_criteria_element.get_unread(),
171171
},

tests/parsers/biorad_bioplex_manager/biorad_bioplex_manager_structure_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ def test_create_well() -> None:
7878
"TotalGatedEvents": "637",
7979
"TotalRegionEventCount": "609",
8080
"Unit": "µl",
81-
"WellNo": "1",
8281
},
8382
)
8483

0 commit comments

Comments
 (0)