refactor: Add get_schema_from_asm (#1037)

Author: nathan-stender

src/allotropy/allotrope/schema_parser/path_util.py

@@ -4,6 +4,8 @@
 import re
 from typing import Any
 
+from allotropy.exceptions import AllotropeValidationError
+
 ALLOTROPE_DIR: Path = Path(__file__).parent.parent
 ALLOTROPY_DIR: Path = ALLOTROPE_DIR.parent
 ROOT_DIR: Path = ALLOTROPE_DIR.parent.parent.parent
@@ -69,6 +71,16 @@ def get_schema_path_from_manifest(manifest: str) -> Path:
     return Path(f"adm/{match.groups()[0]}.schema.json")
 
 
+def get_schema_path_from_asm(asm_dict: Mapping[str, Any]) -> Path:
+    if "$asm.manifest" not in asm_dict:
+        msg = "File is not valid ASM - missing $asm.manifest field"
+        raise AllotropeValidationError(msg)
+    if not isinstance(asm_dict["$asm.manifest"], str):
+        msg = f"File is not valid ASM - $asm.manifest is not a string: {asm_dict['$asm.manifest']}"
+        raise AllotropeValidationError(msg)
+    return get_schema_path_from_manifest(asm_dict["$asm.manifest"])
+
+
 def get_schema_path_from_reference(reference: str) -> Path:
     ref_match = re.match(r"http://purl.allotrope.org/json-schemas/(.*)", reference)
     if not ref_match:
@@ -111,7 +123,7 @@ def get_import_path_from_path(model_path: Path) -> str:
 
 
 def get_model_class_from_schema(asm: Mapping[str, Any]) -> Any:
-    schema_path = get_schema_path_from_manifest(asm["$asm.manifest"])
+    schema_path = get_schema_path_from_asm(asm)
     model_path = get_model_path_from_schema_path(Path(schema_path))
     import_path = get_import_path_from_path(model_path)
     # NOTE: it is safe to assume that every schema module has Model, as we generate this code.

src/allotropy/allotrope/schemas.py

@@ -1,9 +1,11 @@
+from collections.abc import Mapping
 import json
 from pathlib import Path
 from typing import Any
 
 from allotropy.allotrope.schema_parser.path_util import (
     get_full_schema_path,
+    get_schema_path_from_asm,
     get_schema_path_from_manifest,
     SHARED_SCHEMAS_DEFINITIONS_PATH,
 )
@@ -51,6 +53,10 @@ def get_schema_from_manifest(manifest: str) -> dict[str, Any]:
     return get_schema(get_schema_path_from_manifest(manifest))
 
 
+def get_schema_from_asm(asm_dict: Mapping[str, Any]) -> dict[str, Any]:
+    return get_schema(get_schema_path_from_asm(asm_dict))
+
+
 def get_schema_from_model(model: Any) -> dict[str, Any]:
     manifest = getattr(model, "manifest", getattr(model, "field_asm_manifest", None))
     if not manifest:

tests/allotrope/schema_parser/path_util_test.py

@@ -9,6 +9,7 @@
     get_model_path_from_schema_path,
     get_rel_model_path,
     get_rel_schema_path,
+    get_schema_path_from_asm,
     get_schema_path_from_manifest,
     get_schema_path_from_model_path,
     get_schema_path_from_reference,
@@ -54,6 +55,10 @@ def test_get_schema_path_from_manifest() -> None:
     assert get_schema_path_from_manifest(MANIFEST) == REL_SCHEMA_PATH
 
 
+def test_get_schema_path_from_asm() -> None:
+    assert get_schema_path_from_asm({"$asm.manifest": MANIFEST}) == REL_SCHEMA_PATH
+
+
 def test_get_schema_path_from_reference() -> None:
     assert (
         get_schema_path_from_reference(