Skip to content

Commit d592d93

Browse files
slopez-bslopez-b
committed
make sample_id consistent beteween measurements
1 parent 3891373 commit d592d93

2 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎src/allotropy/parsers/cytiva_biacore_insight/cytiva_biacore_insight_structure.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ def create(
379379

380380
return MeasurementData(
381381
identifier=identifier,
382-
sample_identifier=f"Run{run}_Cycle{cycle_number}_Channel{channel}",
382+
sample_identifier=f"Run{run}_Cycle{cycle_number}",
383383
method_name=run_metadata.method_name,
384384
ligand_identifier=run_info.get(str, "Ligand"),
385385
device_control_document=device_control_document,

‎tests/parsers/cytiva_biacore_insight/testdata/Cytiva_Biacore_Insight_Example01.json‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
},
116116
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_0",
117117
"sample document": {
118-
"sample identifier": "Run1_Cycle1_Channel1",
118+
"sample identifier": "Run1_Cycle1",
119119
"custom information document": {
120120
"Run": 1,
121121
"Cycle": 1,
@@ -1029,7 +1029,7 @@
10291029
},
10301030
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_1",
10311031
"sample document": {
1032-
"sample identifier": "Run1_Cycle1_Channel2",
1032+
"sample identifier": "Run1_Cycle1",
10331033
"custom information document": {
10341034
"Run": 1,
10351035
"Cycle": 1,
@@ -1943,7 +1943,7 @@
19431943
},
19441944
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_2",
19451945
"sample document": {
1946-
"sample identifier": "Run1_Cycle1_Channel3",
1946+
"sample identifier": "Run1_Cycle1",
19471947
"custom information document": {
19481948
"Run": 1,
19491949
"Cycle": 1,
@@ -2857,7 +2857,7 @@
28572857
},
28582858
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_3",
28592859
"sample document": {
2860-
"sample identifier": "Run1_Cycle1_Channel4",
2860+
"sample identifier": "Run1_Cycle1",
28612861
"custom information document": {
28622862
"Run": 1,
28632863
"Cycle": 1,
@@ -3771,7 +3771,7 @@
37713771
},
37723772
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_4",
37733773
"sample document": {
3774-
"sample identifier": "Run1_Cycle1_Channel5",
3774+
"sample identifier": "Run1_Cycle1",
37753775
"custom information document": {
37763776
"Run": 1,
37773777
"Cycle": 1,
@@ -4685,7 +4685,7 @@
46854685
},
46864686
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_5",
46874687
"sample document": {
4688-
"sample identifier": "Run1_Cycle1_Channel6",
4688+
"sample identifier": "Run1_Cycle1",
46894689
"custom information document": {
46904690
"Run": 1,
46914691
"Cycle": 1,
@@ -5599,7 +5599,7 @@
55995599
},
56005600
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_6",
56015601
"sample document": {
5602-
"sample identifier": "Run1_Cycle1_Channel7",
5602+
"sample identifier": "Run1_Cycle1",
56035603
"custom information document": {
56045604
"Run": 1,
56055605
"Cycle": 1,
@@ -6513,7 +6513,7 @@
65136513
},
65146514
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_7",
65156515
"sample document": {
6516-
"sample identifier": "Run1_Cycle1_Channel8",
6516+
"sample identifier": "Run1_Cycle1",
65176517
"custom information document": {
65186518
"Run": 1,
65196519
"Cycle": 1,
@@ -7452,7 +7452,7 @@
74527452
},
74537453
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_8",
74547454
"sample document": {
7455-
"sample identifier": "Run1_Cycle2_Channel1",
7455+
"sample identifier": "Run1_Cycle2",
74567456
"custom information document": {
74577457
"Run": 1,
74587458
"Cycle": 2,
@@ -8401,7 +8401,7 @@
84018401
},
84028402
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_9",
84038403
"sample document": {
8404-
"sample identifier": "Run1_Cycle2_Channel2",
8404+
"sample identifier": "Run1_Cycle2",
84058405
"custom information document": {
84068406
"Run": 1,
84078407
"Cycle": 2,
@@ -9350,7 +9350,7 @@
93509350
},
93519351
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_10",
93529352
"sample document": {
9353-
"sample identifier": "Run1_Cycle2_Channel3",
9353+
"sample identifier": "Run1_Cycle2",
93549354
"custom information document": {
93559355
"Run": 1,
93569356
"Cycle": 2,
@@ -10299,7 +10299,7 @@
1029910299
},
1030010300
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_11",
1030110301
"sample document": {
10302-
"sample identifier": "Run1_Cycle2_Channel4",
10302+
"sample identifier": "Run1_Cycle2",
1030310303
"custom information document": {
1030410304
"Run": 1,
1030510305
"Cycle": 2,
@@ -11248,7 +11248,7 @@
1124811248
},
1124911249
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_12",
1125011250
"sample document": {
11251-
"sample identifier": "Run1_Cycle2_Channel5",
11251+
"sample identifier": "Run1_Cycle2",
1125211252
"custom information document": {
1125311253
"Run": 1,
1125411254
"Cycle": 2,
@@ -12197,7 +12197,7 @@
1219712197
},
1219812198
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_13",
1219912199
"sample document": {
12200-
"sample identifier": "Run1_Cycle2_Channel6",
12200+
"sample identifier": "Run1_Cycle2",
1220112201
"custom information document": {
1220212202
"Run": 1,
1220312203
"Cycle": 2,
@@ -13120,7 +13120,7 @@
1312013120
},
1312113121
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_14",
1312213122
"sample document": {
13123-
"sample identifier": "Run1_Cycle2_Channel7",
13123+
"sample identifier": "Run1_Cycle2",
1312413124
"custom information document": {
1312513125
"Run": 1,
1312613126
"Cycle": 2,
@@ -14069,7 +14069,7 @@
1406914069
},
1407014070
"measurement identifier": "CYTIVA_BIACORE_INSIGHT_TEST_ID_15",
1407114071
"sample document": {
14072-
"sample identifier": "Run1_Cycle2_Channel8",
14072+
"sample identifier": "Run1_Cycle2",
1407314073
"custom information document": {
1407414074
"Run": 1,
1407514075
"Cycle": 2,
@@ -38749,7 +38749,7 @@
3874938749
"file name": "evaluation_name",
3875038750
"UNC path": "my_evaluation_path",
3875138751
"ASM converter name": "allotropy_cytiva_biacore_insight",
38752-
"ASM converter version": "0.1.104",
38752+
"ASM converter version": "0.1.105",
3875338753
"software name": "Biacore Insight Evaluation",
3875438754
"software version": "6.0.0.0000"
3875538755
},

0 commit comments

Comments
 (0)