fix: Agilent OpenLab CDS - use bytes to read zip file instead of file name#1021
Merged
Conversation
nathan-stender
marked this pull request as ready for review
June 24, 2025 13:49
ajcariaga16
approved these changes
Jun 24, 2025
nathan-stender
added a commit
that referenced
this pull request
Jun 24, 2025
### Fixed - Agilent OpenLab CDS - use bytes to read zip file instead of file name (#1021)
joshua-benchling
pushed a commit
that referenced
this pull request
Sep 15, 2025
… name (#1021) Allotropy parsers must read from bytes, not from local files, as the interface allows passing in bytes.
joshua-benchling
pushed a commit
that referenced
this pull request
Sep 15, 2025
### Fixed - Agilent OpenLab CDS - use bytes to read zip file instead of file name (#1021)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allotropy parsers must read from bytes, not from local files, as the interface allows passing in bytes.