feat: Molecular Devices SoftMax Pro - move maximum wavelength signal to measurement document#1027
Closed
slopez-b wants to merge 1 commit into
Closed
feat: Molecular Devices SoftMax Pro - move maximum wavelength signal to measurement document#1027slopez-b wants to merge 1 commit into
slopez-b wants to merge 1 commit into
Conversation
slopez-b
changed the title
james-leinas
approved these changes
Jul 2, 2025
nathan-stender
approved these changes
Jul 7, 2025
nathan-stender
requested changes
Jul 7, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes to block merging while we figure out if this should be reported as "reduced" instead
Collaborator
|
Closing per external discussion - we will be moving max wavelength to calc docs |
nathan-stender
deleted the
slopez/smp-move-max-wavelength-signal-to-measurement
branch
July 8, 2025 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reporting
maximum wavelength signalwithin theplate reader documentwas causing issues when parsing ASM in the asm-to-csv converter since the metadata at the "technique document" level is assumed to be the same for all documents.This change also makes sense since it is possible to have several reads per well in
spectrumplates (not supported yet), in which case a differentmaximum wavelength signalwould be reported permeasurement document