Skip to content

refactor: Agilent gen5 - refactor adapter#1038

Merged
nathan-stender merged 7 commits into
mainfrom
jherna/refactor_agilent_gen5
Aug 4, 2025
Merged

refactor: Agilent gen5 - refactor adapter#1038
nathan-stender merged 7 commits into
mainfrom
jherna/refactor_agilent_gen5

Conversation

@joshua-benchling

Copy link
Copy Markdown
Collaborator

No description provided.

@joshua-benchling
joshua-benchling force-pushed the jherna/refactor_agilent_gen5 branch from 38d2c55 to a6088f5 Compare July 23, 2025 23:13
Comment thread src/allotropy/parsers/agilent_gen5/agilent_gen5_parser.py Outdated
Comment thread src/allotropy/parsers/agilent_gen5/agilent_gen5_parser.py Outdated

@nathan-stender nathan-stender left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A couple suggestions for further clarity

Comment thread src/allotropy/parsers/agilent_gen5/agilent_gen5_parser.py Outdated
nathan-stender
nathan-stender previously approved these changes Aug 4, 2025
@nathan-stender
nathan-stender merged commit bdb8dca into main Aug 4, 2025
7 checks passed
@nathan-stender
nathan-stender deleted the jherna/refactor_agilent_gen5 branch August 4, 2025 18:24
nathan-stender added a commit that referenced this pull request Aug 18, 2025
### Added

- Migrate cytiva_unicorn to use get_unread (#1051)
- Roche Cedex BioHT - Add custom information field Flag for sample flags
and error document for < TEST RANGE (#1053)
- BD Biosciences FACSDiva - add get unread data (#1049)

### Changed

- Agilent gen5 - refactor adapter (#1038)
joshua-benchling added a commit that referenced this pull request Sep 15, 2025
Co-authored-by: Nathan Stender <nathan.stender@benchling.com>
joshua-benchling pushed a commit that referenced this pull request Sep 15, 2025
### Added

- Migrate cytiva_unicorn to use get_unread (#1051)
- Roche Cedex BioHT - Add custom information field Flag for sample flags
and error document for < TEST RANGE (#1053)
- BD Biosciences FACSDiva - add get unread data (#1049)

### Changed

- Agilent gen5 - refactor adapter (#1038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants