feat: Cytiva Biacore T200 Control - improve performance#1043
Merged
nathan-stender merged 2 commits intoJul 23, 2025
Conversation
…and DataFrame.at[] assignments with numpy
nathan-stender
approved these changes
Jul 22, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Awesome! Can you add a brief description of what the key improvements were in the PR description - for future reference?
nathan-stender
changed the title
nathan-stender
deleted the
jherna/cytiva_biacore_t200_control_reduce_time_process
branch
July 23, 2025 15:04
joshua-benchling
added a commit
that referenced
this pull request
Sep 15, 2025
Local testing: * Small files: From 6.8 seconds to 0.13 seconds (98% reduction) * Large files: From 67+ seconds to 7.5 seconds (89% reduction) * Core bottleneck: 99.27% time reduction in sensorgram data grouping * Scalability: Performance scales well with file size Co-authored-by: Nathan Stender <nathan.stender@benchling.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local testing:
Key Technical Improvements
DataFrame.at[]assignments with bulk.loc[]operations