Skip to content

feat: Cytiva Unicorn - migrate to use get_unread#1051

Merged
nathan-stender merged 6 commits into
Benchling-Open-Source:mainfrom
felipenarv:felipenarv/migrate_cytiva_unicorn_to_use_get_unread_BNCH_115083
Aug 15, 2025
Merged

feat: Cytiva Unicorn - migrate to use get_unread#1051
nathan-stender merged 6 commits into
Benchling-Open-Source:mainfrom
felipenarv:felipenarv/migrate_cytiva_unicorn_to_use_get_unread_BNCH_115083

Conversation

@felipenarv

@felipenarv felipenarv commented Aug 4, 2025 •
edited by nathan-stender
Loading

Copy link
Copy Markdown
Contributor

Add unread data for Cytiva Unicorn adapter

@felipenarv
felipenarv requested review from a team and slopez-b as code owners August 4, 2025 20:05
@felipenarv
felipenarv requested a review from tamargrey August 4, 2025 20:05
@james-leinas

james-leinas commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

@felipenarv here's my recommendations for the Unicorn unread data

Unicorn Get Unread

Data System Document

  • FormatVersion

Device Control Document

  • ColumnVolume
  • ScanInterval

Data Processing Document

  • IsOriginalData
  • MethodStartTime
  • AmplitudeUnit
  • ChromatogramStartTimeUtcOffsetMinutes
  • AmplitudePrecision
  • CurveDataType
  • IsReadOnly
  • MethodStartTimeUtcOffsetMinutes
  • ColumnVolumeUnitName
  • IsoChroneType
  • CurveNumber
  • ChromatogramStartTime
  • TimeUnit
  • VolumeUnit
  • IsExternal
  • DistancetoStartPoints
  • DistanceBetweenPoints
  • ChromatogramName
  • ChromatogramID

Map to ASM Field

Data System Document

  • UNICORNVersion -> software version

james-leinas
james-leinas requested changes Aug 5, 2025
View reviewed changes
Comment thread tests/parsers/cytiva_unicorn/testdata/unicorn_1.json
Comment thread tests/parsers/cytiva_unicorn/testdata/unicorn_1.json Outdated
Comment thread tests/parsers/cytiva_unicorn/testdata/unicorn_1.json Outdated
Comment thread tests/parsers/cytiva_unicorn/testdata/unicorn_1.json Outdated
Comment thread tests/parsers/cytiva_unicorn/testdata/unicorn_1.json Outdated
@felipenarv
felipenarv requested a review from james-leinas August 6, 2025 19:52
james-leinas
james-leinas requested changes Aug 8, 2025
View reviewed changes
Comment thread tests/parsers/cytiva_unicorn/testdata/unicorn_1.json Outdated
james-leinas
james-leinas approved these changes Aug 12, 2025
View reviewed changes

@james-leinas james-leinas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@felipenarv

felipenarv commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

@nathan-stender @tamargrey Can one of you help me with a review here? The changes were already approved by James

@nathan-stender
nathan-stender merged commit cf67c75 into Benchling-Open-Source:main Aug 15, 2025
7 checks passed
@nathan-stender nathan-stender changed the title feat: Migrate cytiva_unicorn to use get_unread feat: Cytiva Unicorn - migrate to use get_unread Aug 15, 2025
@nathan-stender nathan-stender mentioned this pull request Aug 18, 2025
Merged
nathan-stender added a commit that referenced this pull request Aug 18, 2025
@nathan-stender
release: Update allotropy version to 0.1.103 (#1058)
dff8542 
### Added

- Migrate cytiva_unicorn to use get_unread (#1051)
- Roche Cedex BioHT - Add custom information field Flag for sample flags
and error document for < TEST RANGE (#1053)
- BD Biosciences FACSDiva - add get unread data (#1049)

### Changed

- Agilent gen5 - refactor adapter (#1038)
joshua-benchling pushed a commit that referenced this pull request Sep 15, 2025
@felipenarv
feat: Migrate cytiva_unicorn to use get_unread (#1051)
d11fadc 
Code for [BNCH-115083](https://jira.benchling.team/browse/BNCH-115083)
joshua-benchling pushed a commit that referenced this pull request Sep 15, 2025
@nathan-stender
release: Update allotropy version to 0.1.103 (#1058)
eca07ea 
### Added

- Migrate cytiva_unicorn to use get_unread (#1051)
- Roche Cedex BioHT - Add custom information field Flag for sample flags
and error document for < TEST RANGE (#1053)
- BD Biosciences FACSDiva - add get unread data (#1049)

### Changed

- Agilent gen5 - refactor adapter (#1038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tamargrey tamargrey tamargrey approved these changes
@nathan-stender nathan-stender nathan-stender approved these changes
@james-leinas james-leinas james-leinas approved these changes
@slopez-b slopez-b Awaiting requested review from slopez-b slopez-b is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felipenarv @james-leinas @tamargrey @nathan-stender