feat: Migrate luminex_xponent to use SeriesData.get_unread#1052
Closed
oscar-castro-bl wants to merge 17 commits into
Closed
feat: Migrate luminex_xponent to use SeriesData.get_unread#1052oscar-castro-bl wants to merge 17 commits into
oscar-castro-bl wants to merge 17 commits into
Conversation
nathan-stender
requested changes
Aug 5, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
@oscar-castro-bl running hatch run test tests/parsers/luminex_xponent/ --warn_unread_keys still yields warnings - please address before putting up the PR for review
nathan-stender
requested changes
Aug 5, 2025
…o luminex_xponent_get_unread
oscar-castro-bl
marked this pull request as draft
August 6, 2025 16:20
james-leinas
requested changes
Aug 6, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
Luminex xPONENT Unread Data
Skip Custom Information Fields
- Date
Custom Information Field Placement
Device System Document
- Country Code
- ProtocolDevelopingCompany
- Version
Device Control Document
- ProtocolHeater
- DDGate
- SampleTimeout
- ProtocolAnalysis
- ProtocolMicrosphere
- PlateReadDirection
Measurement Aggregate Document
- BatchStopTime
- ProtocolDescription
Sample Document
- BatchDescription
- PanelName
- BeadType
oscar-castro-bl
marked this pull request as ready for review
August 20, 2025 16:19
…o luminex_xponent_get_unread
oscar-castro-bl
requested review from
james-leinas,
joshua-benchling and
nathan-stender
August 20, 2025 16:30
james-leinas
previously approved these changes
Aug 20, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
ASM changes LGTM 👍
nathan-stender
requested changes
Aug 20, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Much closer!
I have a few additional changes regarding avoiding calling get_unread and throwing away data in some places, but this is jus about done!
…o luminex_xponent_get_unread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.