Skip to content

feat: Luminex IntelliFlex - Added support for single table files#1061

Merged
nathan-stender merged 6 commits into
Benchling-Open-Source:mainfrom
felipenarv:felipenarv/luminex_intelliflex_addd_support_for_single_dataset_file
Sep 2, 2025
Merged

feat: Luminex IntelliFlex - Added support for single table files#1061
nathan-stender merged 6 commits into
Benchling-Open-Source:mainfrom
felipenarv:felipenarv/luminex_intelliflex_addd_support_for_single_dataset_file

Conversation

@felipenarv

@felipenarv felipenarv commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@felipenarv
felipenarv requested review from a team and slopez-b as code owners August 25, 2025 16:22
@felipenarv
felipenarv requested a review from tamargrey August 25, 2025 16:22
@felipenarv felipenarv changed the title Luminex IntelliFlex - Added support for single table files feat: Luminex IntelliFlex - Added support for single table files Aug 25, 2025
james-leinas
james-leinas requested changes Aug 26, 2025
View reviewed changes
Comment thread src/allotropy/parsers/luminex_xponent/luminex_xponent_structure.py Outdated
Comment thread src/allotropy/parsers/luminex_xponent/luminex_xponent_structure.py Outdated
@nathan-stender
nathan-stender removed request for a team, slopez-b and tamargrey August 27, 2025 14:23
james-leinas
james-leinas previously approved these changes Aug 28, 2025
View reviewed changes

@james-leinas james-leinas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASM LGTM 🎉

nathan-stender
nathan-stender requested changes Aug 28, 2025
View reviewed changes

@nathan-stender nathan-stender left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mostly LGTM - a few nits

Comment thread src/allotropy/parsers/luminex_xponent/luminex_xponent_reader.py Outdated
Comment thread tests/parsers/luminex_intelliflex/testdata/luminex_intelliflex_single_dataset.csv
Comment thread src/allotropy/parsers/lines_reader.py Outdated
Comment thread src/allotropy/parsers/constants.py Outdated
Comment thread src/allotropy/parsers/luminex_xponent/luminex_xponent_reader.py Outdated
@nathan-stender
nathan-stender merged commit f69003c into Benchling-Open-Source:main Sep 2, 2025
7 checks passed
@nathan-stender nathan-stender mentioned this pull request Sep 2, 2025
Merged
nathan-stender added a commit that referenced this pull request Sep 2, 2025
@nathan-stender
release: Update allotropy version to 0.1.105 (#1069)
3c0a571 
### Added

- Flowjo Improve performance (#1067)
- Luminex IntelliFlex - Added support for single table files (#1061)

### Changed

- Add schema validation function for external use (#1068)
joshua-benchling pushed a commit that referenced this pull request Sep 15, 2025
@felipenarv
feat: Luminex IntelliFlex - Added support for single table files (#1061)
8b3f401
joshua-benchling pushed a commit that referenced this pull request Sep 15, 2025
@nathan-stender
release: Update allotropy version to 0.1.105 (#1069)
3911b79 
### Added

- Flowjo Improve performance (#1067)
- Luminex IntelliFlex - Added support for single table files (#1061)

### Changed

- Add schema validation function for external use (#1068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathan-stender nathan-stender nathan-stender approved these changes
@james-leinas james-leinas james-leinas left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felipenarv @nathan-stender @james-leinas