Skip to content

chore: Add quote handling to conversion #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-stender merged 4 commits into from
Aug 29, 2025
+4 −3
Merged

chore: Add quote handling to conversion #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fed08b
Add underscore
nathan-stender Aug 29, 2025
5da0d3e
Actually this
nathan-stender Aug 29, 2025
4c628c7
Merge branch 'main' into nstender-new-key-check
nathan-stender Aug 29, 2025
03df24a
Test all the wierd keys
nathan-stender Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/allotropy/allotrope/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
"^": "_CARET_",
"=": "_EQUALS_",
"@": "_AT_",
"'": "_QUOTE_",
# NOTE: this MUST be at the end, or it will break other key replacements.
" ": "_",
}
Expand Down
6 changes: 3 additions & 3 deletions tests/allotrope/converter_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ def test_custom_information_document() -> None:
cycle_threshold_value_setting=TQuantityValueUnitless(value=1.0),
),
),
{"extra key": "Value", "weird-key/(value)°": "Other value"},
{"extra key": "Value", "$w.e\\ir:[d]-k'e~y/(v^a=l@ue)°#": "Other value"},
)

assert item.custom_information_document.extra_key == "Value" # type: ignore
assert item.custom_information_document.weird_DASH_key_SLASH__OPAREN_value_CPAREN__DEG_ == "Other value" # type: ignore
assert item.custom_information_document._DOLLAR_w_POINT_e_BSLASH_ir_COLON__OBRACKET_d_CBRACKET__DASH_k_QUOTE_e_TILDE_y_SLASH__OPAREN_v_CARET_a_EQUALS_l_AT_ue_CPAREN__DEG__NUMBER_ == "Other value" # type: ignore
asm_dict = unstructure(item)
assert asm_dict == {
"cycle threshold result": {"value": None, "unit": "(unitless)"},
Expand All @@ -148,7 +148,7 @@ def test_custom_information_document() -> None:
},
"custom information document": {
"extra key": "Value",
"weird-key/(value)°": "Other value",
"$w.e\\ir:[d]-k'e~y/(v^a=l@ue)°#": "Other value",
},
}
assert structure(asm_dict, ProcessedDataDocumentItem) == item
Expand Down
Loading