feat: Flowjo Improve performance - #1067
Merged
Merged
Conversation
nathan-stender
approved these changes
Sep 2, 2025
nathan-stender
added a commit
that referenced
this pull request
Sep 2, 2025
joshua-benchling
added a commit
that referenced
this pull request
Sep 15, 2025
Improve processing time to convert to ASM. Key improvements: * Built a per-sample keyword map once and reused it for all lookups, eliminating repeated Keywords XML scans. * Precomputed root-level, cytometer, and SampleList fields once outside the sample loop and merged them, avoiding per-sample attribute re-reads. * Replaced repeated keyword extraction functions with set-based filters over the keyword map (O(1) lookups, iterate smaller of keys vs map). * Used the keyword map for common fields (measurement time, analyst, well/plate IDs, written name) to avoid extra traversals. --------- Co-authored-by: Nathan Stender <nathan.stender@benchling.com>
joshua-benchling
pushed a commit
that referenced
this pull request
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve processing time to convert to ASM.
Key improvements: