feat: NovaBio Flex2 - use SeriesData.get_unread#1070
Merged
nathan-stender merged 6 commits intoSep 9, 2025
Merged
Conversation
felipenarv
requested review from
nathan-stender
and removed request for
a team
September 3, 2025 17:31
james-leinas
requested changes
Sep 4, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
NovaBio Flex2 Unread Data
Skip
- Sample Time
- PCO2 @ Temp
- PO2 @ Temp
- pH @ Temp
- Operator
- Osm
Device Control Document
- Sparging O2%
- pH / Gas Flow Time
- Vessel Pressure (psi)
- Chemistry Flow Time
- Valid Images
- Cell Density Flow
Sample Document
- Cell Type
- Cell Inspection Type
- Vessel ID
- Chemistry Dilution Ratio
- Pre-Dilution Multiplier
james-leinas
previously approved these changes
Sep 5, 2025
Contributor
Author
|
@nathan-stender Can you give it a look? I added that decorator to prevent the warning from being raised in specific functions |
nathan-stender
requested changes
Sep 8, 2025
nathan-stender
approved these changes
Sep 9, 2025
joshua-benchling
pushed a commit
that referenced
this pull request
Sep 15, 2025
<img width="773" height="320" alt="image" src="https://github.com/user-attachments/assets/1e21fb64-776d-4ca5-9af6-99e0fbe5e390" />
nathan-stender
added a commit
that referenced
this pull request
Sep 30, 2025
### Added - AppBio QuantStudio Design & Analysis - remove duplicates and hardcoded values from measurement custom info doc (#1088) - Tecan Magellan - remove unread keys warning (#1086) - Beckman Coulter Biomek - Add handle for unified transfer and pipetting samples (#1085) - Agilent OpenLab CDS - add peak area percentage and peak height (#1083) - Roche Cedex Bioht - use get_unread (#1084) - Chemometec NC View - Migrated to use get unread (#1082) - Migrate beckman_pharmspec to use SeriesData.get_unread (#1081) - Beckman Coulter Biomek Liquid Handler - add support for log headerless files (#1078) - Migrate ctl_immunospot to use SeriesData.get_unread (#1076) - Cytiva Biacore Insight/Cytiva Biacore T200 Control - Update Slope calculated data's reported units to RU/s (#1077) - Molecular Devices SoftMax Pro - Add unread data (#1071) - Perkin elmer envision get unread (#1073) - BMG mars - Migrate to use get_unread info (#1074) - Unchained Labs Lunnatic & Stunner - refactor measurements to use data cubes for wavelength spectrums (#1062) - Cytiva Biacore Insight - initial implementation (#1066) - NovaBio Flex2 - use SeriesData.get_unread (#1070) - Migrate revvity_kaleido to use SeriesData.get_unread (#1060) ### Fixed - Binding Affinity Analyzer - add support for special keys in processed data document (#1087)
3 tasks
nathan-stender
added a commit
that referenced
this pull request
Jun 29, 2026
…x2 parser (#1236) ## Summary - `Sample Time`, `PCO2 @ Temp`, `PO2 @ Temp`, and `pH @ Temp` were incorrectly marked as `unused_keys` in the NovaBio Flex2 parser (introduced in #1070) - These fields are not duplicates of already-mapped ASM fields — they were skipped by mistake during the PR review categorization - Removed them from `unused_keys` so they now flow through to `custom_info` in the output - `Operator` and `Osm` remain suppressed since they are consumed elsewhere (as `analyst` and `osmolality` respectively) ## Test plan - [x] All 13 NovaBio Flex2 tests pass - [x] discover_vendor tests pass - [x] Lint clean (ruff, black, mypy) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.