feat: Perkin elmer envision get unread - #1073
Merged
Merged
Conversation
oscar-castro-bl
marked this pull request as draft
September 8, 2025 21:06
oscar-castro-bl
marked this pull request as ready for review
September 9, 2025 15:39
james-leinas
requested changes
Sep 10, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
Perkin Elmer Envision Unread Data
Device Control Document
- Ambient temperature at start
- Humidity at start
- Chamber temperature at end
- Humidity at end
- Kinetics
- Ambient temperature at end
- ScanX
- ScanY
- Inside temperature at start
- Inside temperature at end
Sample Document
- Repeat
- Group -> change name to group identifier to match allotrope term
james-leinas
previously approved these changes
Sep 11, 2025
Collaborator
Author
|
@nathan-stender can you take a look? |
nathan-stender
requested changes
Sep 12, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Code so far LGTM - but there are still unread data warnings when I run
hatch run test tests/parsers/perkin_elmer_envision/ --warn_unread_keys
…o perkin_elmer_envision_get_unread
…o perkin_elmer_envision_get_unread
james-leinas
requested changes
Sep 15, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
Perkin Elmer Unread Data 2.0
Skip
- Serial# -- already captured by equipment serial number
Device Control Document
- Height of the plate
- Number of columns
- Number of rows
Sample Document
- Name of the plate type
Measurement Aggregate Document
- Protocol Name
- Assay Started
- Assay Finished
- Assay Exported
nathan-stender
requested changes
Sep 16, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Updated code looks good.
Going to request changes to remove my review request until you address @james-leinas's review.
Re-request when ready for final approval!
…o perkin_elmer_envision_get_unread
nathan-stender
approved these changes
Sep 16, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Code LGTM - please wait for @james-leinas to approve before merging!
nathan-stender
added a commit
that referenced
this pull request
Sep 30, 2025
### Added - AppBio QuantStudio Design & Analysis - remove duplicates and hardcoded values from measurement custom info doc (#1088) - Tecan Magellan - remove unread keys warning (#1086) - Beckman Coulter Biomek - Add handle for unified transfer and pipetting samples (#1085) - Agilent OpenLab CDS - add peak area percentage and peak height (#1083) - Roche Cedex Bioht - use get_unread (#1084) - Chemometec NC View - Migrated to use get unread (#1082) - Migrate beckman_pharmspec to use SeriesData.get_unread (#1081) - Beckman Coulter Biomek Liquid Handler - add support for log headerless files (#1078) - Migrate ctl_immunospot to use SeriesData.get_unread (#1076) - Cytiva Biacore Insight/Cytiva Biacore T200 Control - Update Slope calculated data's reported units to RU/s (#1077) - Molecular Devices SoftMax Pro - Add unread data (#1071) - Perkin elmer envision get unread (#1073) - BMG mars - Migrate to use get_unread info (#1074) - Unchained Labs Lunnatic & Stunner - refactor measurements to use data cubes for wavelength spectrums (#1062) - Cytiva Biacore Insight - initial implementation (#1066) - NovaBio Flex2 - use SeriesData.get_unread (#1070) - Migrate revvity_kaleido to use SeriesData.get_unread (#1060) ### Fixed - Binding Affinity Analyzer - add support for special keys in processed data document (#1087)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.