feat: Cytiva Biacore T200 Evaluation Module - initial implementation - #1075
Merged
Conversation
joshua-benchling
marked this pull request as draft
September 16, 2025 16:39
joshua-benchling
marked this pull request as ready for review
September 17, 2025 16:24
nathan-stender
requested changes
Sep 18, 2025
joshua-benchling
force-pushed
the
jherna/cytiva-biacore-evaluation-module
branch
from
September 22, 2025 15:19
2f75e0a to
f8ae6f0
Compare
nathan-stender
requested changes
Sep 22, 2025
james-leinas
previously approved these changes
Sep 23, 2025
nathan-stender
requested changes
Sep 26, 2025
joshua-benchling
force-pushed
the
jherna/cytiva-biacore-evaluation-module
branch
from
October 1, 2025 16:55
c2a800d to
da6197f
Compare
…cument integration - Implement kinetic analysis extraction (kon, koff, KD, Rmax) with proper units - Add custom information documents for kinetic errors and Chi2 values - Support reference-subtracted flow cells (e.g., 2-1, 3-1, 4-1) - Process multiple cycles and flow cells with proper filtering - Integrate DeviceControlDocument class for device control data - Add sensor chip custom information fields - Set up Git LFS for large binary test files (.bme)
- Change measurement identifier from concatenated string to simple UUID - Reference-subtracted flow cells (2-1, 3-1, 4-1) already have correct flow cell identifiers - Data cube labels automatically use reference-subtracted IDs for proper identification
- Update _normalize_flow_cell_id to preserve hyphenated flow cell IDs (e.g., '2-1', '3-1', '4-1') - Remove duplicate reference-subtracted flow cell creation loop since they exist in sensorgram data - Now reference-subtracted flow cells will have correct identifiers in both flow_cell_identifier and data cube labels - Simplifies code by processing all flow cells in single loop
- Add 'lfs: true' to all actions/checkout@v3 steps in test workflow - This ensures .bme test files are properly downloaded as binary content - Fixes 'not an OLE2 structured storage file' error in remote pipeline
joshua-benchling
force-pushed
the
jherna/cytiva-biacore-evaluation-module
branch
from
October 1, 2025 20:04
da6197f to
824ae82
Compare
nathan-stender
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.