Skip to content

feat: Migrate ctl_immunospot to use SeriesData.get_unread - #1076

Merged
nathan-stender merged 8 commits into
mainfrom
ctl_immunospot_get_unread
Sep 19, 2025
Merged

feat: Migrate ctl_immunospot to use SeriesData.get_unread#1076
nathan-stender merged 8 commits into
mainfrom
ctl_immunospot_get_unread

Conversation

@oscar-castro-bl

Copy link
Copy Markdown
Collaborator

No description provided.

@james-leinas james-leinas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CTL ImmunoSpot UnRead Data

Skip

  • Authenticated User -- already mapped to analyst

Measurement Aggregate Document

  • Assay
  • Counted
  • Review Date

Device Control Document

  • Edge Effect Compensation
  • Edge Compensation Level
  • Normalize Counts of Max
  • Objects
  • Diffuseness
  • Counting window size
  • Counting mask size (%)
  • Background Balance
  • Auto Areas
  • Manual Areas
  • Scanning
  • Counting

Image Feature Document

  • Min. SpotSize
  • Max. SpotSize
  • Spot Separation

james-leinas
james-leinas previously approved these changes Sep 18, 2025
@oscar-castro-bl

Copy link
Copy Markdown
Collaborator Author

@nathan-stender would you mind giving it a look? thanks

Comment thread tests/parsers/ctl_immunospot/testdata/ctl_immunospot_v7_0_38_8_QC.json Outdated

@nathan-stender nathan-stender left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! A couple small changes.

Also looks like James has a request

Comment thread src/allotropy/parsers/ctl_immunospot/ctl_immunospot_reader.py Outdated
Comment thread src/allotropy/parsers/utils/pandas.py Outdated
Comment thread src/allotropy/allotrope/converter.py Outdated
@nathan-stender
nathan-stender merged commit df24d50 into main Sep 19, 2025
7 checks passed
@nathan-stender
nathan-stender deleted the ctl_immunospot_get_unread branch September 19, 2025 15:38
nathan-stender added a commit that referenced this pull request Sep 30, 2025
### Added

- AppBio QuantStudio Design & Analysis - remove duplicates and hardcoded
values from measurement custom info doc (#1088)
- Tecan Magellan - remove unread keys warning (#1086)
- Beckman Coulter Biomek - Add handle for unified transfer and pipetting
samples (#1085)
- Agilent OpenLab CDS - add peak area percentage and peak height (#1083)
- Roche Cedex Bioht - use get_unread (#1084)
- Chemometec NC View - Migrated to use get unread (#1082)
- Migrate beckman_pharmspec to use SeriesData.get_unread (#1081)
- Beckman Coulter Biomek Liquid Handler - add support for log headerless
files (#1078)
- Migrate ctl_immunospot to use SeriesData.get_unread (#1076)
- Cytiva Biacore Insight/Cytiva Biacore T200 Control - Update Slope
calculated data's reported units to RU/s (#1077)
- Molecular Devices SoftMax Pro - Add unread data (#1071)
- Perkin elmer envision get unread (#1073)
- BMG mars - Migrate to use get_unread info (#1074)
- Unchained Labs Lunnatic & Stunner - refactor measurements to use data
cubes for wavelength spectrums (#1062)
- Cytiva Biacore Insight - initial implementation (#1066)
- NovaBio Flex2 - use SeriesData.get_unread (#1070)
- Migrate revvity_kaleido to use SeriesData.get_unread (#1060)

### Fixed

- Binding Affinity Analyzer - add support for special keys in processed
data document (#1087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants