feat: Migrate beckman_pharmspec to use SeriesData.get_unread - #1081
Merged
Conversation
oscar-castro-bl
changed the title
james-leinas
requested changes
Sep 22, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
Beckman PharmSpec UnRead Data
Skip
- "Nan"
- Run No. -- already mapped to
measurement identifier
Device Control Document
- Sensor Model -- rename as
model numberin custom information
Sample Document
- Batch-Nr -- rename as
batch identifierin custom information, if value is"-"we should ignore from adding to ASM, None value
Measurement Document
- Ro-Nr -- if value is
"-"we should ignore from adding to ASM, None value - Bemerkungen 1 -- rename to
observation 1, if value is"-"we should ignore from adding to ASM, None value - Bemerkungen 2 -- rename to
observation 2, if value is"-"we should ignore from adding to ASM, None value
…o beckman_pharmaspec_get_unread
ajcariaga16
previously approved these changes
Sep 24, 2025
james-leinas
previously approved these changes
Sep 24, 2025
nathan-stender
requested changes
Sep 25, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Mostly LGTM - one change
oscar-castro-bl
dismissed stale reviews from james-leinas and ajcariaga16
via
September 25, 2025 15:29
57eca33
nathan-stender
approved these changes
Sep 25, 2025
nathan-stender
added a commit
that referenced
this pull request
Sep 30, 2025
### Added - AppBio QuantStudio Design & Analysis - remove duplicates and hardcoded values from measurement custom info doc (#1088) - Tecan Magellan - remove unread keys warning (#1086) - Beckman Coulter Biomek - Add handle for unified transfer and pipetting samples (#1085) - Agilent OpenLab CDS - add peak area percentage and peak height (#1083) - Roche Cedex Bioht - use get_unread (#1084) - Chemometec NC View - Migrated to use get unread (#1082) - Migrate beckman_pharmspec to use SeriesData.get_unread (#1081) - Beckman Coulter Biomek Liquid Handler - add support for log headerless files (#1078) - Migrate ctl_immunospot to use SeriesData.get_unread (#1076) - Cytiva Biacore Insight/Cytiva Biacore T200 Control - Update Slope calculated data's reported units to RU/s (#1077) - Molecular Devices SoftMax Pro - Add unread data (#1071) - Perkin elmer envision get unread (#1073) - BMG mars - Migrate to use get_unread info (#1074) - Unchained Labs Lunnatic & Stunner - refactor measurements to use data cubes for wavelength spectrums (#1062) - Cytiva Biacore Insight - initial implementation (#1066) - NovaBio Flex2 - use SeriesData.get_unread (#1070) - Migrate revvity_kaleido to use SeriesData.get_unread (#1060) ### Fixed - Binding Affinity Analyzer - add support for special keys in processed data document (#1087)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.