Skip to content

feat: Thermo Fisher Scientific Genesys30 - add unread data #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-benchling merged 4 commits into from
Oct 8, 2025
Merged

feat: Thermo Fisher Scientific Genesys30 - add unread data #1093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a4be9f
add get unread data, remove unread warnings
joshua-benchling Oct 2, 2025
406eb65
lint
joshua-benchling Oct 2, 2025
5557690
rename custom field Length to number of sampled points
joshua-benchling Oct 2, 2025
bd0b3b2
Merge branch 'main' into jherna/thermo-fisher-genesys-30-get-unread
joshua-benchling Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/allotropy/parsers/thermo_fisher_genesys30/thermo_fisher_genesys30_structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ def create_measurement_groups(
"value": header.get(float, "Upper"),
"unit": "nm",
},
"number of sampled points": header.get(int, "Length"),
**header.get_unread(),
},
),
],
Expand Down
5 changes: 3 additions & 2 deletions tests/parsers/thermo_fisher_genesys30/testdata/thermo_fisher_genesys30_example_01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"operating maximum": {
"value": 480.0,
"unit": "nm"
}
},
"number of sampled points": 156
}
}
]
Expand Down Expand Up @@ -74,7 +75,7 @@
"UNC path": "tests/parsers/thermo_fisher_genesys30/testdata/thermo_fisher_genesys30_example_01.tsv",
"software name": "Genesys 30 instrument software",
"ASM converter name": "allotropy_thermo_fisher_scientific_genesys30",
"ASM converter version": "0.1.76"
"ASM converter version": "0.1.106"
}
}
}
5 changes: 3 additions & 2 deletions tests/parsers/thermo_fisher_genesys30/testdata/thermo_fisher_genesys30_example_02.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"operating maximum": {
"value": 480.0,
"unit": "nm"
}
},
"number of sampled points": 156
}
}
]
Expand Down Expand Up @@ -74,7 +75,7 @@
"UNC path": "tests/parsers/thermo_fisher_genesys30/testdata/thermo_fisher_genesys30_example_02.csv",
"software name": "Genesys 30 instrument software",
"ASM converter name": "allotropy_thermo_fisher_scientific_genesys30",
"ASM converter version": "0.1.76"
"ASM converter version": "0.1.106"
}
}
}
Loading