feat: Thermo Fisher Scientific NanoDrop 8000 - add unread data to asm - #1094
Merged
Conversation
joshua-benchling
commented
Oct 2, 2025
joshua-benchling
commented
Collaborator
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Code LGTM - but pending @james-leinas review for approval
james-leinas
requested changes
Oct 9, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
NanoDrop 8000 Unread Data
Skip
- Date -- Captured as measurement time
- Time -- Captured as measurement time
- User id -- Captured as analyst
- A60/A80 -- Captured as Calculated Data
- A260/A230 -- Captured as Calculated Data
- formula value 1
- formula name 1
- formula 1
Device Control Document
- Cursor Pos. -- Report as TQuantity Value (nm -- nanometers)
Measurement Document
- Cursor Abs. -- Report as TQuantity Value (mAU -- milli absorbance units)
- 340 raw -- Report as TQuantity Value (mAU -- milli absorbance units)
Sample Document
- Mol. Wt. kda -- Report as TQuantity Value (kDa -- KiloDaltons)
Data Processing Document
- E1% -- Report as TQuantity Value (unitless)
- ext. coeff x10e3 -- Report as TQuantity Value (M-1cm-1 -- PerMolarPerCentimeter), note will have to be added to units.py
- ext.c. (l/(mol*cm)) -- Report as TQuantity Value (M-1cm-1 -- PerMolarPerCentimeter)
- Conc. Factor (ng/uL) -- Report as TQuantity Value (ng/uL -- nanograms per microliter)
james-leinas
previously approved these changes
Oct 15, 2025
nathan-stender
requested changes
Oct 16, 2025
james-leinas
previously approved these changes
Oct 24, 2025
nathan-stender
previously approved these changes
Oct 24, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - looks like you've got a conflict - you can ping me to re-approve!
joshua-benchling
dismissed stale reviews from nathan-stender and james-leinas
via
October 27, 2025 16:56
95e1ce9
joshua-benchling
force-pushed
the
jherna/nanodrop-8000-get_unread
branch
from
October 27, 2025 16:56
0e1fea6 to
95e1ce9
Compare
nathan-stender
approved these changes
Oct 28, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.