feat: Cytiva Biacore T200 - Refactor to use JsonData - #1095
Merged
nathan-stender merged 11 commits intoOct 24, 2025
Merged
Conversation
nathan-stender
requested changes
Oct 3, 2025
slopez-b
reviewed
Oct 10, 2025
joshua-benchling
previously approved these changes
Oct 16, 2025
joshua-benchling
left a comment
joshua-benchling
left a comment
Collaborator
There was a problem hiding this comment.
Good implementation for wrapping up nested dicts. Left optional comments
nathan-stender
previously approved these changes
Oct 24, 2025
felipenarv
dismissed stale reviews from nathan-stender and joshua-benchling
via
October 24, 2025 16:06
0fe98bc
joshua-benchling
approved these changes
Oct 24, 2025
nathan-stender
approved these changes
Oct 24, 2025
nathan-stender
added a commit
that referenced
this pull request
Oct 28, 2025
### Added - Thermo Fisher Scientific VISIONlite - add get unread data (#1097) - Flowjo - Added new example (#1108) - Beckman Coulter Biomek - clear unread data warnings (#1092) - Cytiva Biacore T200 - Refactor to use JsonData (#1095) - CTL ImmunoSpot - use proper units in data processing document (#1098) - Thermo Fisher Scientific SkanIt - add unread data (#1104) ### Fixed - Molecular Devices SoftMax Pro - handle reduced data blocks with empty rows correctly (#1110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically replaced DictType with JsonData, which keeps track of which keys have been called and create a warning when the object is deleted without having read all keys