feat: Thermo Fisher Scientific NanoDrop Eight - add unread data to asm - #1096
Merged
Conversation
joshua-benchling
commented
Oct 3, 2025
joshua-benchling
commented
Collaborator
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Code LGTM - pending @james-leinas review for fields.
If we can't figure out a better name for the ng/µL column - I'll prob ask to figure out how to remove the odd encoding character too, but let's see if we want to rename the column first.
james-leinas
requested changes
Oct 9, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
NanoDrop Eight Unread Data
Skip
- user name -- Already captured as analyst
- A260/A230 -- Already captured as Calculated Data
- A260/A280 -- Already captured as Calculated Data
- date & time -- Already captured as measurement time
- serial number -- Already captured as equipment serial number
- WeirdExtra
- AndMore
Measurement Aggregate Document
- Add user name to be captured as analyst as well for this file https://github.com/Benchling-Open-Source/allotropy/blob/3f8d52266c626fa2ed726ab574f6f1de53c6b964/tests/parsers/thermo_fisher_nanodrop_eight/testdata/thermo_nanodrop_eight_RNA.json
Sample Document
- Sample Name
Processed Data Document
- ng/âμl --> mass concentration (TQuantityValue nanograms per microliters, ng/uL)
james-leinas
previously approved these changes
Oct 22, 2025
nathan-stender
requested changes
Oct 24, 2025
joshua-benchling
force-pushed
the
jherna/nanodrop-eight-get_unread
branch
from
October 27, 2025 18:58
7d4a20f to
1c95a76
Compare
nathan-stender
approved these changes
Oct 28, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.