feat: Qiacuity dPCR - Added unread data - #1103
Merged
nathan-stender merged 5 commits intoNov 13, 2025
Merged
Conversation
Contributor
Author
|
@james-leinas Is that new custom data in the correct place? That's the only unread data I saw |
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
Code LGTM - pending @james-leinas's approval for location
james-leinas
requested changes
Oct 14, 2025
james-leinas
left a comment
james-leinas
left a comment
Collaborator
There was a problem hiding this comment.
Qiacuity Unread Data
Measurement Document
- Reaction Mix
Sample Document
- IC -- if value is "-" or blank we should not include in ASM JSON
- Control Type -- if value is "-" or blank we should not include in ASM JSON
Also looks like we have some calculated data that we should be capturing into the ASM
Calculated Data Document
- Calculated Data Name: CI (95%), Data Source Identifier/Aggregating Property: Measurement Identifier, Units: #/μL
- Calculated Data Name: SD, Data Source Identifier/Aggregating Property: Measurement Identifier, Units: (unitless)
- Calculated Data Name: CV%, Data Source Identifier/Aggregating Property: Measurement Identifier, Units: %
- Calculated Data Name: Mean Concentration, Data Source Identifier: Measurement Identifier, Aggregating Property: Sample Identifier, Units: #/μL
felipenarv
force-pushed
the
felipenarv/qiacuity_dpcr_get_unread
branch
from
October 22, 2025 19:00
66c815a to
5437d3d
Compare
james-leinas
requested changes
Oct 22, 2025
james-leinas
previously approved these changes
Oct 23, 2025
nathan-stender
requested changes
Oct 24, 2025
james-leinas
approved these changes
Oct 28, 2025
nathan-stender
approved these changes
Nov 11, 2025
joshua-benchling
self-requested a review
November 11, 2025 18:10
nathan-stender
added a commit
that referenced
this pull request
Nov 19, 2025
### Added - JSON-to-CSV - improve list parsing to better support datacubes (#1124) - Cytiva Biacore T200 control - add unread data (#1120) - Qiacuity dPCR - Added unread data (#1103) - Migrate biorad_bioplex_manager to use SeriesData.get_unread (#1100) - Mass spectrometer ASM schema (#1121) - Roche Cedex BioHT - Add support for mM unit (mmol/L) (#1119)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.