feat: BMG Mars - Support for CSVs generated by Mars V3.40 R2 - #1105
Merged
Conversation
nathan-stender
approved these changes
Oct 23, 2025
nathan-stender
left a comment
nathan-stender
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - thank you for contributing!
Collaborator
|
@Cynicjon thank you again for the contribution! Feel free to add yourself to the authors list in the pyproject if you want! Not if you're using Benchling or using allotropy independently, but if you're using Benchling - I will publish a package version today and update Benchling - the update usually lands within a day or two! |
nathan-stender
added a commit
that referenced
this pull request
Oct 23, 2025
### Added - BMG Labtech MARS - Support for CSVs generated by Mars V3.40 R2 (#1105)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BMG Mars V3.40 R2 generates malformed CSVs that have missing end of line separators. This PR adds support to enable successful parsing of those files.
A test case was added, adapted from another test case, more real tests be provided if required