perf: Cytiva Biacore T200 Evaluation Module - Added optimizations on decoding logic - #1109
Conversation
|
@joshua-benchling and @slopez-b would you be able to give an initial review of Felipe's PR here? Thanks! |
joshua-benchling
left a comment
There was a problem hiding this comment.
Great performance key improvements, left a question.
Also if you can provide a description on how much the performance was increased would be good.
|
@joshua-benchling I added some explanations of what was done and why it works. As for the general performance, this is the result of a script that runs a test with the current code in main and this. The performance is -58% because it is taking this branch as the base and the code in main as the "new" code. The real improvement is like 37%, less than the 50% I had because I was just timing the code in the parser, this runs the entire test |
felipenarv
left a comment
There was a problem hiding this comment.
Added some comments explaining why the improvements should work
…acore_t200_evaluation_decoder.py Co-authored-by: joshua-benchling <jherna@benchling.com> Signed-off-by: felipenarv <felipe.narvaez@benchling.com>
The improvement of this update is aprox 37%. This was calculated by running a script that switches from the existing code to the code on the HEAD. The performance below is -58% because it is taking this branch as the base and the code in main as the "new" code. The real improvement is like 37%, less than the 50% I had because I was just timing the code in the parser, this runs the entire test.
This also add a t-test to be sure the improvement is statistically relevant