fix: Molecular Devices SoftMax Pro - handle reduced data blocks with empty rows correctly - #1110
Merged
Merged
Conversation
nathan-stender
changed the title
ajcariaga16
approved these changes
Oct 28, 2025
nathan-stender
added a commit
that referenced
this pull request
Oct 28, 2025
### Added - Thermo Fisher Scientific VISIONlite - add get unread data (#1097) - Flowjo - Added new example (#1108) - Beckman Coulter Biomek - clear unread data warnings (#1092) - Cytiva Biacore T200 - Refactor to use JsonData (#1095) - CTL ImmunoSpot - use proper units in data processing document (#1098) - Thermo Fisher Scientific SkanIt - add unread data (#1104) ### Fixed - Molecular Devices SoftMax Pro - handle reduced data blocks with empty rows correctly (#1110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw data blocks are read using plate dimensions, but reduced data blocks were being parsed with
pop_csv_block_as_dfwhich ends at an empty line.This does not always work for reduced blocks either, which may have empty rows (row a row of wells with no measurements). So use plate dimensions for reduced blocks as well.
The function to read using plate dimensions is factored out to allow for code reuse.