fix: Thermo Fisher Scientific SkanIt - error detecing plate word matching - #1113
Merged
joshua-benchling merged 3 commits intoOct 31, 2025
Merged
Conversation
ajcariaga16
reviewed
Oct 30, 2025
james-leinas
approved these changes
Oct 30, 2025
nathan-stender
approved these changes
Oct 31, 2025
joshua-benchling
deleted the
jherna/fix_skanit_handle_different_plate_pattern
branch
October 31, 2025 17:06
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The adapter is looking for plates with the pattern "Plate \d+" (e.g., "Plate 1", "Plate 2"), but new test data has "Blank plate" and "Sample Plate" instead, which don't match the regex pattern r"Plate\s*(\d+)". This causes the method to return an empty list.
Fix:
Updated the plate matching logic in thermo_skanit_structure.py to match "Sample Plate" and "Blank Plate" as well.