Skip to content

feat: Qiacuity dPCR - add handle for first column containing the well #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-benchling merged 2 commits into from
Dec 17, 2025
Merged

feat: Qiacuity dPCR - add handle for first column containing the well #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
412cc59
add handle for first column containing the well
joshua-benchling Dec 10, 2025
675de0a
Merge branch 'main' into jherna/qiacuity-handle-well-first-column
joshua-benchling Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/allotropy/parsers/qiacuity_dpcr/qiacuity_dpcr_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,14 @@ def __init__(self, named_file_contents: NamedFileContents):
qiacuity_dpcr_data.columns = qiacuity_dpcr_data.columns.str.replace("�", "μ")
qiacuity_dpcr_data.columns = qiacuity_dpcr_data.columns.str.replace("Âμ", "μ")
column_names = qiacuity_dpcr_data.columns.tolist()
# Rename the blank column to specify that it's the Well Name column
column_names[0] = "Well Name"
if "Well" in column_names:
# Rename "Well" to "Well Name" for consistency
column_names = [
"Well Name" if col == "Well" else col for col in column_names
]
else:
# Rename the blank first column to specify that it's the Well Name column
column_names[0] = "Well Name"
column_index = pd.Index(column_names)
qiacuity_dpcr_data.columns = column_index
self.well_data = qiacuity_dpcr_data
25 changes: 19 additions & 6 deletions src/allotropy/parsers/qiacuity_dpcr/qiacuity_dpcr_structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ def create_measurements(data: SeriesData) -> Measurement:

identifier = data.get(str, "_measurement_identifier") or random_uuid_str()

sample_custom_info = data.get_custom_keys({"IC", "Control type"})
sample_custom_info = data.get_custom_keys(
{"IC", "Control type", "Target (IC)", "Target (Control)"}
)
for key in sample_custom_info:
if sample_custom_info[key] in ("", "-", "-", "--"):
sample_custom_info[key] = None
Expand All @@ -43,11 +45,22 @@ def create_measurements(data: SeriesData) -> Measurement:
sample_role_type=sample_role_type,
location_identifier=data[str, "Well Name"],
plate_identifier=data.get(str, "Plate ID"),
target_identifier=data[str, "Target"],
total_partition_count=data[int, "Partitions (valid)"],
concentration=data[float, ["Concentration (copies/μL)", "Conc. [copies/μL]"]],
positive_partition_count=data[int, "Partitions (positive)"],
negative_partition_count=data.get(int, "Partitions (negative)"),
target_identifier=data[str, ["Target", "Target (Name)"]],
total_partition_count=data[int, ["Partitions (valid)", "Partitions (Valid)"]],
concentration=data[
float,
[
"Concentration (copies/μL)",
"Conc. [copies/μL]",
"Conc. [cp/μL] (dPCR reaction)",
],
],
positive_partition_count=data[
int, ["Partitions (positive)", "Partitions (Positive)"]
],
negative_partition_count=data.get(
int, ["Partitions (negative)", "Partitions (Negative)"]
),
fluorescence_intensity_threshold_setting=data.get(float, "Threshold"),
sample_custom_info=sample_custom_info,
custom_info=data.get_unread(),
Expand Down
34 changes: 34 additions & 0 deletions tests/parsers/qiacuity_dpcr/testdata/qiacuity_dpcr_example04.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
sep=,
"Plate name","Plate ID","Plate type","Well","Sample/NTC/Control","Type","Reaction Mix","Target (Name)","Target (IC)","Target (Control)","Conc. [cp/µL] (dPCR reaction)","Conc. [cp/mL] (dPCR reaction)","CI (95%) (dPCR reaction)","Conc. [cp/µL] (undiluted sample)","Conc. [cp/mL] (undiluted sample)","Partitions (Valid)","Partitions (Positive)","Partitions (Negative)","Threshold","Volume per well [µl]","Concentration factor","Template volume [µl]","Total volume [µl]","Conversion factor","Conversion unit"
"250227 AAV MA 6","2186f026-541d-438c-8195-2a1da8a81e56","Nanoplate 8.5K 96-well","A1","1_5000","Sample","eGFP","eGFP","-","-","7782.4","7782381.203592551","2.9%","1686182594.1","1686182594111.7194","8261","7644","617","19.45","2.837","50000","3.6","15.6","1000","cp/mL"
"","","","A2","1_5000","Sample","eGFP","eGFP","-","-","8243.3","8243312.142179277","3.0%","1786050964.1","1786050964138.843","8220","7693","527","19.45","2.836","50000","3.6","15.6","1000","cp/mL"
"","","","A3","1_10000","Sample","eGFP","eGFP","-","-","4331.8","4331802.288772191","2.7%","1877114325.1","1877114325134.616","8251","6314","1937","19.45","2.847","100000","3.6","15.6","1000","cp/mL"
"","","","A4","1_10000","Sample","eGFP","eGFP","-","-","4131.6","4131574.801895133","2.7%","1790349080.8","1790349080821.2242","8258","6179","2079","19.45","2.841","100000","3.6","15.6","1000","cp/mL"
"","","","A5","GFP+_10000","Sample","eGFP","eGFP","-","-","4273.2","4273167.253847267","2.7%","185170581.0","185170581000.04822","8258","6262","1996","19.45","2.828","10000","3.6","15.6","1000","cp/mL"
"","","","B1","2_5000","Sample","eGFP","eGFP","-","-","7293.9","7293931.173215276","2.9%","1580351754.2","1580351754196.643","8268","7545","723","19.45","2.843","50000","3.6","15.6","1000","cp/mL"
"","","","B2","2_5000","Sample","eGFP","eGFP","-","-","7501.9","7501877.055196923","2.9%","1625406695.3","1625406695292.6664","8256","7539","717","19.45","2.772","50000","3.6","15.6","1000","cp/mL"
"","","","B3","2_10000","Sample","eGFP","eGFP","-","-","3881.2","3881217.559902232","2.7%","1681860942.6","1681860942624.3005","8265","5922","2343","19.45","2.764","100000","3.6","15.6","1000","cp/mL"
"","","","B4","2_10000","Sample","eGFP","eGFP","-","-","3841.0","3841025.99623931","2.7%","1664444598.4","1664444598370.3673","8263","5840","2423","19.45","2.718","100000","3.6","15.6","1000","cp/mL"
"","","","B5","GFP+_10000","Sample","eGFP","eGFP","-","-","4308.0","4307999.978497452","2.7%","186679999.1","186679999068.2229","8263","6181","2082","19.45","2.723","10000","3.6","15.6","1000","cp/mL"
"","","","C1","3_5000","Sample","eGFP","eGFP","-","-","8421.5","8421468.976341419","3.0%","1824651611.5","1824651611540.6408","8257","7738","519","19.45","2.796","50000","3.6","15.6","1000","cp/mL"
"","","","C2","3_5000","Sample","eGFP","eGFP","-","-","8345.5","8345452.807031626","3.0%","1808181441.5","1808181441523.5188","8268","7686","582","19.45","2.706","50000","3.6","15.6","1000","cp/mL"
"","","","C3","3_10000","Sample","eGFP","eGFP","-","-","4496.9","4496934.671644322","2.7%","1948671691.0","1948671691045.873","8281","6296","1985","19.45","2.703","100000","3.6","15.6","1000","cp/mL"
"","","","C4","3_10000","Sample","eGFP","eGFP","-","-","4286.8","4286843.191831076","2.7%","1857632049.8","1857632049793.4663","8280","6114","2166","19.45","2.662","100000","3.6","15.6","1000","cp/mL"
"","","","C5","GFP+_10000","Sample","eGFP","eGFP","-","-","4460.6","4460641.102538355","2.7%","193294447.8","193294447776.66205","8257","6193","2064","19.45","2.645","10000","3.6","15.6","1000","cp/mL"
"","","","D1","4_5000","Sample","eGFP","eGFP","-","-","7045.4","7045441.152649994","2.8%","1526512249.7","1526512249740.832","8285","7476","809","19.45","2.81","50000","3.6","15.6","1000","cp/mL"
"","","","D2","4_5000","Sample","eGFP","eGFP","-","-","7069.1","7069057.464728602","2.8%","1531629117.4","1531629117357.8637","8278","7418","860","19.45","2.726","50000","3.6","15.6","1000","cp/mL"
"","","","D3","4_10000","Sample","eGFP","eGFP","-","-","3853.2","3853186.510478793","2.7%","1669714154.5","1669714154540.8099","8257","5821","2436","19.45","2.696","100000","3.6","15.6","1000","cp/mL"
"","","","D4","4_10000","Sample","eGFP","eGFP","-","-","3657.5","3657500.634484687","2.8%","1584916941.6","1584916941610.0307","8276","5640","2636","19.45","2.662","100000","3.6","15.6","1000","cp/mL"
"","","","D5","GFP+_10000","Sample","eGFP","eGFP","-","-","4623.5","4623482.543713903","2.7%","200350910.2","200350910227.60248","8269","6251","2018","19.45","2.596","10000","3.6","15.6","1000","cp/mL"
"","","","E1","5_5000","Sample","eGFP","eGFP","-","-","6629.6","6629628.363322401","2.8%","1436419478.7","1436419478719.8536","8274","7345","929","19.45","2.807","50000","3.6","15.6","1000","cp/mL"
"","","","E2","5_5000","Sample","eGFP","eGFP","-","-","6718.0","6718029.225576681","2.8%","1455572998.9","1455572998874.9473","8275","7313","962","19.45","2.726","50000","3.6","15.6","1000","cp/mL"
"","","","E3","5_10000","Sample","eGFP","eGFP","-","-","3537.6","3537560.946733544","2.8%","1532943076.9","1532943076917.8689","8263","5510","2753","19.45","2.644","100000","3.6","15.6","1000","cp/mL"
"","","","E4","5_10000","Sample","eGFP","eGFP","-","-","3386.7","3386703.056941245","2.8%","1467571324.7","1467571324674.5393","8264","5398","2866","19.45","2.661","100000","3.6","15.6","1000","cp/mL"
"","","","E5","NTC_1","Sample","eGFP","eGFP","-","-","0.000","0.000","-","0.000","0.000","8263","0","8263","19.45","2.621","1","3.6","15.6","1000","cp/mL"
"","","","F1","6_5000","Sample","eGFP","eGFP","-","-","6685.3","6685344.814481614","2.8%","1448491376.5","1448491376471.0164","8259","7350","909","19.45","2.809","50000","3.6","15.6","1000","cp/mL"
"","","","F2","6_5000","Sample","eGFP","eGFP","-","-","6638.5","6638452.811055944","2.8%","1438331442.4","1438331442395.4546","8247","7287","960","19.45","2.757","50000","3.6","15.6","1000","cp/mL"
"","","","F3","6_10000","Sample","eGFP","eGFP","-","-","3545.9","3545949.866982259","2.8%","1536578275.7","1536578275692.3122","8249","5601","2648","19.45","2.727","100000","3.6","15.6","1000","cp/mL"
"","","","F4","6_10000","Sample","eGFP","eGFP","-","-","3456.3","3456298.662462109","2.8%","1497729420.4","1497729420400.2473","8212","5382","2830","19.45","2.623","100000","3.6","15.6","1000","cp/mL"
"","","","F5","NTC_1","Sample","eGFP","eGFP","-","-","0.000","0.000","-","0.000","0.000","6287","0","6287","19.45","2.639","1","3.6","15.6","1000","cp/mL"
"","","","G5","NTC_1","Sample","eGFP","eGFP","-","-","0.386","385.539138675","147.5%","1.671","1670.669600924","8249","1","8248","19.45","2.676","1","3.6","15.6","1000","cp/mL"
"","","","H5","NTC_1","Sample","eGFP","eGFP","-","-","0.000","0.000","-","0.000","0.000","8211","0","8211","19.45","2.734","1","3.6","15.6","1000","cp/mL"
Loading
Loading