Skip to content

fix: Fix GitHub Actions hatch/virtualenv compatibility #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-stender merged 3 commits into from
Mar 11, 2026
Merged

fix: Fix GitHub Actions hatch/virtualenv compatibility #1140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96bdd57
fix: Update GitHub Actions workflow to fix hatch/virtualenv compatibi…
nathan-stender Mar 11, 2026
7ad9288
chore: Add CHROM/ directory to .gitignore
nathan-stender Mar 11, 2026
1cc1bcf
fix: Pin chardet below 6.0.0 to resolve encoding test failures
nathan-stender Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ jobs:
name: Tests (python 3.10)

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
lfs: true
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Install hatch
run: pip install hatch
run: pip install "hatch>=1.13.0"
- name: Install click
run: pip install click!=8.3.0
- name: Run Tests
Expand All @@ -36,14 +36,14 @@ jobs:
name: Tests (python 3.11)

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
lfs: true
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: "3.11.9"
- name: Install hatch
run: pip install hatch
run: pip install "hatch>=1.13.0"
# NOTE: due to bug: https://github.com/pallets/click/issues/3066
- name: Install click
run: pip install click!=8.3.0
Expand All @@ -56,14 +56,14 @@ jobs:
name: Tests (python 3.12)

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
lfs: true
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: "3.12"
- name: Install hatch
run: pip install hatch
run: pip install "hatch>=1.13.0"
- name: Install click
run: pip install click!=8.3.0
- name: Run Tests
Expand All @@ -75,14 +75,14 @@ jobs:
name: Quality Checks

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
lfs: true
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: "3.11.9"
- name: Install hatch
run: pip install hatch
run: pip install "hatch>=1.13.0"
- name: Install click
run: pip install click!=8.3.0
- name: Lint
Expand All @@ -93,7 +93,7 @@ jobs:
name: Check PR Title

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
lfs: true
- name: Check PR title
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,3 +223,4 @@ fabric.properties
#VSCode
.vscode/launch.json
.vscode/settings.json
CHROM/
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ classifiers = [
]
dependencies = [
"cattrs >= 23.2.0",
"chardet >= 5.2.0",
"chardet >= 5.2.0, < 6.0.0",
"defusedxml >= 0.7.1",
# NOTE: jsonschema 4.18.0 introduces a serious performance regression, seemingly due to use of new
# referencing library.
Expand Down
Loading