test: Optimize test file sizes for faster CI execution (batch 2)#1151
Open
nathan-stender wants to merge 6 commits into
Open
test: Optimize test file sizes for faster CI execution (batch 2)#1151nathan-stender wants to merge 6 commits into
nathan-stender wants to merge 6 commits into
Conversation
- Reduced PE_Envision_luminescence_example01.csv from 263 to 151 lines - Kept representative rows (A, E, I, M) from 384-well plates - JSON file reduced from 3.95MB to 965KB (76% reduction) - Maintains test coverage with representative data samples
- Reduced data rows from 8 (A-H) to 4 representative rows (A, C, E, G) - TXT file reduced from 7.9KB to 4.9KB (38% reduction) - JSON file reduced from 1.77MB to 867KB (51% reduction) - Maintains test coverage with representative data patterns
- endpoint_singleplate_filter.txt: 127 → 71 lines, JSON 1.8MB → 567KB (69% reduction) - endpoint_fluorescence_polarization.txt: 152 → 72 lines, JSON 3.6MB → 1.1MB (69% reduction) - Kept representative rows (A, D, H, L, P) from 384-well plates while maintaining test coverage
- Reduced from 32 rows to 6 representative rows (A, G, M, S, Y, e) - CSV: 41 → 16 lines - JSON: 2.4MB → 460KB (81% reduction) - Maintains test coverage for 1536-well plate data
…e modified The detect-changes job was failing when only test files (not source files) were changed because grep returns exit code 1 when no matches are found, and the workflow runs with set -e (exit on error). Added || true to grep commands to prevent the script from exiting when no source files match the pattern. Co-Authored-By: Claude Opus 4.1 <noreply@anthropic.com>
Collaborator
Author
|
Fixed the detect-changes job failure. The issue was that grep returns exit code 1 when no matches are found, and since the workflow runs with set -e, it was causing the script to exit when only test files (not source files) were modified. Added || true to the grep commands to handle this case properly. The CI should now run correctly. |
ajcariaga16
previously approved these changes
Mar 17, 2026
# Conflicts: # tests/parsers/perkin_elmer_envision/testdata/PE_Envision_luminescence_example01.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the test file optimization effort to reduce CI execution time by optimizing large test data files while maintaining test coverage.
(Replaces #1150 - rebased onto latest main to fix workflow issues)
Changes
Optimized 5 large test files by reducing redundant data rows while keeping representative samples:
Files Optimized
Perkin Elmer Envision luminescence_example01.csv
Methodical Mind methodical_test_2.txt
Agilent Gen5 endpoint_singleplate_filter.txt
Agilent Gen5 endpoint_fluorescence_polarization.txt
BMG MARS 24-10-16 15-09-52 Luminescence 1536.csv
Impact
Testing
Related