fix: Fix Perkin Elmer Envision parser to recognize A450 labels as absorbance - #1152
Merged
Conversation
… as absorbance The parser was incorrectly defaulting absorbance measurements with labels like "A450", "A562", etc. to fluorescence type. This fix adds pattern matching for the common "A###" absorbance wavelength naming convention (e.g., A450 for 450nm absorbance). Added test case with representative A450 absorbance data to prevent regression. Co-Authored-By: Claude Opus 4.1 <noreply@anthropic.com>
- Move re.match import to top of file with other imports - Change Result.value from int to float to preserve decimal precision - Parse values using float() instead of int() to avoid rounding - Update all test data files to use float values consistently This ensures absorbance values like 0.1500 are preserved instead of being rounded to 0. Co-Authored-By: Claude Opus 4.1 <noreply@anthropic.com>
Collaborator
Author
|
Update: Additional fixes added Changes in latest commit:
All tests passing ✅ |
nathan-stender
changed the title
ajcariaga16
approved these changes
Mar 16, 2026
james-leinas
approved these changes
Mar 16, 2026
nathan-stender
added a commit
that referenced
this pull request
Mar 17, 2026
### Added - Cytiva Biacore Insight - Add support for Affinity and Concentration analysis files (#1137) - Add compatibility with chardet 6.0.0+ and fix encoding issues (#1141) ### Fixed - Fix Perkin Elmer Envision parser to recognize A450 labels as absorbance (#1152) - Optimize test encoding detection for 4x speedup (#1143) - Fix GitHub Actions hatch/virtualenv compatibility (#1140)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The parser's
get_read_type()function was defaulting to fluorescence for any unrecognized label. Absorbance measurements using the common "A###" naming pattern (where ### is the wavelength, e.g., A450 for 450nm absorbance) were not recognized by the existing pattern matching.Solution
Added a regex pattern check
r"^A\d{3}"to identify labels starting with 'A' followed by three digits as absorbance measurements.Test plan
PE_Envision_absorbance_A450_example.csvwith representative A450 data🤖 Generated with Claude Code