Skip to content

feat: Add XLSX support to MSD Workbench parser#1154

Merged
nathan-stender merged 2 commits into
mainfrom
feat/msd-workbench-xlsx-support
Mar 21, 2026
Merged

feat: Add XLSX support to MSD Workbench parser#1154
nathan-stender merged 2 commits into
mainfrom
feat/msd-workbench-xlsx-support

Conversation

@nathan-stender

Copy link
Copy Markdown
Collaborator

Summary

  • Added support for parsing XLSX files in the MSD Workbench parser
  • Parser now accepts .xlsx files in addition to existing .csv and .txt formats
  • XLSX files are read from the "Workbench data" sheet using pandas with openpyxl engine

Changes

  • Updated SUPPORTED_EXTENSIONS in MSDWorkbenchReader to include "xlsx"
  • Added conditional logic to handle XLSX files differently from CSV/TXT files
  • Created sanitized test XLSX file with fake data (no customer-specific information)
  • Generated expected JSON output for the test file

Test plan

  • Added test case with XLSX file (test_msd_workbench_xlsx.xlsx)
  • All existing tests continue to pass
  • Linting and type checking pass
  • Parser correctly reads and processes XLSX files from the "Workbench data" sheet

🤖 Generated with Claude Code

- Update SUPPORTED_EXTENSIONS to include 'xlsx'
- Add logic to read Excel files using pd.read_excel with openpyxl engine
- Read data from 'Workbench data' sheet for XLSX files
- Add test case with sanitized XLSX file and expected JSON output

Co-Authored-By: Claude Opus 4.1 <noreply@anthropic.com>
@nathan-stender
nathan-stender requested review from a team and slopez-b as code owners March 19, 2026 14:36

@slopez-b slopez-b left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathan-stender
nathan-stender merged commit 951a578 into main Mar 21, 2026
9 checks passed
@nathan-stender
nathan-stender deleted the feat/msd-workbench-xlsx-support branch March 21, 2026 20:05
nathan-stender added a commit that referenced this pull request Mar 27, 2026
### Added

- MSD Workbench - Update support for CSV format and Calc Conc CV
handling (#1157)
- Add XLSX support to MSD Workbench parser (#1154)

### Fixed

- Thermo Skanit - Initialize plate_well_count to prevent
UnboundLocalError (#1156)
- AppBio QuantStudio Design & Analysis - Check for valid rq values
before setting r_sample and r_target (#1138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants