feat: MSD Workbench - Update support for CSV format and Calc Conc CV handling#1157
Merged
Conversation
… column This commit adds support for a new MSD Workbench CSV format where the plate ID appears on the first line without trailing commas (e.g., "Plate_TEST001" instead of "Plate_TEST001,,,,,,,,,,,,,,,,"). Changes: - Updated msd_workbench_reader.py to detect and handle both CSV formats: - Old format: Plate ID with trailing commas - New format: Plate ID without commas (line 1 = plate ID, line 2 = headers) - Added support for "Calc. Conc. CV" calculated data column - Improved column name handling to support both "Dilution Factor" and "Dilution" - Added msd_workbench_test_2.csv test file with dummy data for new format - Updated test_msd_workbench_xlsx.json to properly classify calculated data fields Calculated Data Improvements: - "Calc. Conc. CV" now properly appears in calculated data documents - "Dilution" field now correctly consumed by dilution factor setting All existing tests pass with full backwards compatibility maintained. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nathan-stender
approved these changes
Mar 26, 2026
This was referenced Mar 26, 2026
nathan-stender
added a commit
that referenced
this pull request
Mar 27, 2026
### Added - MSD Workbench - Update support for CSV format and Calc Conc CV handling (#1157) - Add XLSX support to MSD Workbench parser (#1154) ### Fixed - Thermo Skanit - Initialize plate_well_count to prevent UnboundLocalError (#1156) - AppBio QuantStudio Design & Analysis - Check for valid rq values before setting r_sample and r_target (#1138)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: