Skip to content

feat: Migrate example_weyland_yutani to REC/2025/03 plate reader schema#1177

Merged
nathan-stender merged 3 commits into
mainfrom
migrate-example-weyland-yutani-rec-2025-03
Apr 16, 2026
Merged

feat: Migrate example_weyland_yutani to REC/2025/03 plate reader schema#1177
nathan-stender merged 3 commits into
mainfrom
migrate-example-weyland-yutani-rec-2025-03

Conversation

@nathan-stender

Copy link
Copy Markdown
Collaborator

Summary

  • Migrate example_weyland_yutani tutorial parser from BENCHLING/2023/09 to REC/2025/03 plate reader schema mapper
  • First step in upgrading plate reader parsers off vendor-specific BENCHLING schemas

Code Changes

Parser file: Updated model and mapper imports from benchling._2023._09rec._2025._03

Structure file:

  • Updated schema mapper imports
  • Added two new required Metadata fields: asm_file_identifier and data_system_instance_id
  • Moved analytical_method_identifier and experimental_data_identifier from MeasurementGroup to individual Measurement instances (per REC/2025/03 schema structure)

JSON Output Changes

All measurement data values are preserved identically. Structural changes:

Change Details
Manifest URL BENCHLING/2023/09REC/2025/03
New fields ASM file identifier, data system instance identifier (N/A)
Field moves analytical method identifier and experimental data identifier moved from measurement aggregate document to each measurement document item
Field ordering Some fields reordered within objects (cosmetic, different model field order)

Fields deleted in test data:

  • root['plate reader aggregate document']['plate reader document'][0]['measurement aggregate document']['analytical method identifier']
  • root['plate reader aggregate document']['plate reader document'][0]['measurement aggregate document']['experimental data identifier']

(These fields moved to individual measurement documents, not actually lost)

Migration Status (Plate Reader BENCHLING Parsers)

Parser Status Reason
example_weyland_yutani This PR FLUORESCENCE only — clean migration
mabtech_apex Blocked OPTICAL_IMAGING only — type removed from REC
agilent_gen5_image Blocked OPTICAL_IMAGING only — type removed from REC
ctl_immunospot Blocked OPTICAL_IMAGING only — type removed from REC
revvity_kaleido Blocked Mixed types including OPTICAL_IMAGING

Test plan

  • pytest tests/parsers/example_weyland_yutani/ --force-overwrite — 2/2 pass
  • Full lint (ruff + black + mypy) — clean
  • Pre-push hook — 547/547 tests pass

🤖 Generated with Claude Code

…er schema

Replace BENCHLING/2023/09 schema mapper with the standard REC/2025/03
version. This is the first step in migrating plate reader parsers off
vendor-specific BENCHLING schemas where possible.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nathan-stender
nathan-stender requested review from a team and slopez-b as code owners April 16, 2026 08:38
@nathan-stender
nathan-stender merged commit fa55d5d into main Apr 16, 2026
9 checks passed
@nathan-stender
nathan-stender deleted the migrate-example-weyland-yutani-rec-2025-03 branch April 16, 2026 23:21
nathan-stender added a commit that referenced this pull request Apr 20, 2026
### Added

- Add Intelliflex v2.2 flat CSV format support (#1184)
- Migrate example_weyland_yutani to REC/2025/03 plate reader schema
(#1177)
- Add technique shorthand to schema scripts (#1178)

### Changed

- Implement modular schema generation  (#1176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants