Skip to content

feat: Migrate cell_counting parsers to REC 2026/03 schema#1180

Open
nathan-stender wants to merge 2 commits into
mainfrom
migrate-cell-counting-rec-2026-03
Open

feat: Migrate cell_counting parsers to REC 2026/03 schema#1180
nathan-stender wants to merge 2 commits into
mainfrom
migrate-cell-counting-rec-2026-03

Conversation

@nathan-stender

Copy link
Copy Markdown
Collaborator

Summary

Migrates all 6 cell_counting parsers from REC 2024/09 to REC 2026/03:

  • beckman_vi_cell_blu
  • beckman_vi_cell_xr
  • chemometec_nc_view
  • chemometec_nucleoview
  • revvity_matrix
  • roche_cedex_hires

Changes

New files

  • 2026/03 schema mapper: src/allotropy/allotrope/schema_mappers/adm/cell_counting/rec/_2026/_03/cell_counting.py
  • Downloaded schemas: schemas/adm/cell-counting/REC/2026/03/ + core/qudt dependencies
  • Generated models: models/adm/cell_counting/rec/_2026/_03/ + core dependencies

Import path updates (12 parser source files)

All parser *_parser.py and *_structure.py files updated from rec._2024._09 to rec._2026._03.

Mapper changes from 2024/09

  • Field rename: average_live_cell_diameter__cell_counter_average_viable_cell_diameter__cell_counter_ (model field renamed in 2026/03 schema)
  • group_identifier promoted: Moved from SampleDocument custom info to native ProcessedDataDocumentItem.group_identifier field
  • experimental_data_identifier: Now also set directly on MeasurementDocumentItem (in addition to ImageDocumentItem)

JSON test data audit (31 files)

Change Scope Description
Manifest URL All 31 files REC/2024/09REC/2026/03
ASM converter version All 31 files Various → 0.1.118
Key ordering All 31 files JSON keys reordered to follow 2026/03 schema-defined order. data system document and device system document now appear before cell counting document array. Fields within objects sorted per schema order.
Field rename beckman_vi_cell_blu, beckman_vi_cell_xr "average live cell diameter (cell counter)""average viable cell diameter (cell counter)"
group_identifier move roche_cedex_hires (4 files) "group identifier" moved from sample document > custom information document to processed data document as a native field

No changes to measurement values, cell counts, densities, diameters, viabilities, or any other numeric data.

Test plan

  • hatch run test:test tests/parsers/{all 6 parsers}/ — 35 passed
  • hatch run lint — clean
  • hatch run lint:typing — clean
  • Pre-push hook (770 tests) — all pass

🤖 Generated with Claude Code

Migrate all 6 cell_counting parsers from REC 2024/09 to REC 2026/03.
Includes downloading the schema, generating model code, creating the
2026/03 schema mapper, and updating all parser imports.

Parsers migrated:
- beckman_vi_cell_blu
- beckman_vi_cell_xr
- chemometec_nc_view
- chemometec_nucleoview
- revvity_matrix
- roche_cedex_hires

Structural changes in the migration:
- Field renamed: average_live_cell_diameter__cell_counter_ →
  average_viable_cell_diameter__cell_counter_ (JSON: "average live cell
  diameter (cell counter)" → "average viable cell diameter (cell counter)")
- group_identifier promoted from SampleDocument custom info to native
  field on ProcessedDataDocumentItem
- experimental_data_identifier now also set on MeasurementDocumentItem
  (in addition to ImageDocumentItem)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nathan-stender
nathan-stender requested review from a team and slopez-b as code owners April 16, 2026 23:25
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants