feat: Migrate pcr (qPCR) parsers to REC 2026/03 schema#1181
Open
nathan-stender wants to merge 3 commits into
Open
feat: Migrate pcr (qPCR) parsers to REC 2026/03 schema#1181nathan-stender wants to merge 3 commits into
nathan-stender wants to merge 3 commits into
Conversation
Migrate all 3 qPCR parsers from REC 2024/09 to REC 2026/03. Includes downloading the schema, generating model code, creating the 2026/03 schema mapper, and updating all parser imports. Parsers migrated: - appbio_quantstudio - appbio_quantstudio_designandanalysis - cfxmaestro Structural changes in the migration: - experimental_data_identifier remains required on MeasurementAggregateDocument AND is also now available on MeasurementDocumentItem (set at both levels) - group_identifier promoted from SampleDocument custom info to native field on ProcessedDataDocumentItem - DeviceSystemDocument now imported from qpcr model (not hierarchy), removing the type: ignore comment - Added experimental_data_identifier to generated MeasurementAggregateDocument model (schema requires it but code generator missed it since the property is inherited via $ref rather than defined inline) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restores the compact single-line format for numeric arrays in data cube structures that was lost during JSON key reordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajcariaga16
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all 3 qPCR parsers from REC 2024/09 to REC 2026/03:
Changes
New files
src/allotropy/allotrope/schema_mappers/adm/pcr/rec/_2026/_03/qpcr.pyschemas/adm/pcr/REC/2026/03/+ core/qudt dependenciesmodels/adm/pcr/rec/_2026/_03/+ core dependenciesImport path updates (11 parser source files)
All parser files updated from
rec._2024._09torec._2026._03.Mapper changes from 2024/09
MeasurementAggregateDocument(required by schema) AND now also set on eachMeasurementDocumentItemSampleDocumentcustom info to nativeProcessedDataDocumentItem.group_identifierfield# type: ignorecommentGenerated model fix
experimental_data_identifier: TStringValuetoMeasurementAggregateDocumentin the generated model — the 2026/03 schema requires this field at the MAD level but the code generator missed it because the property is inherited via$refrather than defined inline in the schema'spropertiesblock.JSON test data audit (40 files)
REC/2024/09→REC/2026/030.1.118"group identifier"moved fromsample document > custom information documenttoprocessed data documentas a native fieldNo changes to measurement values, cycle thresholds, targets, sample identifiers, data cube arrays, or any other scientific data.
Test plan
hatch run test:test tests/parsers/{all 3 parsers}/— 56 passedhatch run lint— cleanhatch run lint:typing— clean🤖 Generated with Claude Code