feat: Migrate solution_analyzer parsers to REC 2026/03 schema#1182
Open
nathan-stender wants to merge 2 commits into
Open
feat: Migrate solution_analyzer parsers to REC 2026/03 schema#1182nathan-stender wants to merge 2 commits into
nathan-stender wants to merge 2 commits into
Conversation
Migrate all 2 solution_analyzer parsers from REC 2024/09 to REC 2026/03. Includes downloading the schema + dependencies, generating model code, creating the 2026/03 schema mapper, and updating all parser imports. Parsers migrated: - beckman_pharmspec - roche_cedex_bioht Structural changes in the migration: - Field renamed: average_live_cell_diameter__cell_counter_ → average_viable_cell_diameter__cell_counter_ - Fixed incomplete generated bga/blood_gas_detector model (stub for unused dependency) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajcariaga16
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all 2 solution_analyzer parsers from REC 2024/09 to REC 2026/03:
Changes
New files
src/allotropy/allotrope/schema_mappers/adm/solution_analyzer/rec/_2026/_03/solution_analyzer.pyschemas/adm/solution-analyzer/REC/2026/03/+ many dependency schemas (absorbance, bga, cell-counting, light-obscuration, metabolite-analyzer, osmolality, ph, core, qudt)models/adm/solution_analyzer/rec/_2026/_03/+ dependency modelsImport path updates (4 parser source files + 1 test file)
All parser
*_parser.pyand*_structure.pyfiles, plusbeckman_pharmspec_parser_test.py, updated fromrec._2024._09torec._2026._03.Mapper changes from 2024/09
average_live_cell_diameter__cell_counter_→average_viable_cell_diameter__cell_counter_REC/2024/09→REC/2026/03Other fixes
bga/blood_gas_detector.pymodel (code generator produced a broken stub; replaced with valid minimal type alias since it's an unused dependency)JSON test data audit (12 files)
REC/2024/09→REC/2026/030.1.118No changes to measurement values, analyte concentrations, cell counts, distribution data, or any other scientific data. This was the simplest migration — no field moves or structural changes in the output.
Test plan
hatch run test:test tests/parsers/{both parsers}/— 35 passedhatch run lint— cleanhatch run lint:typing— clean🤖 Generated with Claude Code