fix: Fall back to .tabular.schema.json in manifest lookup#1190
Merged
Conversation
get_schema_path_from_manifest hardcoded .schema.json suffix, but LC REC/2023/03 and REC/2024/03 schemas are named .tabular.schema.json. This caused validate_asm_schema to raise FileNotFoundError for those techniques. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajcariaga16
previously approved these changes
Apr 21, 2026
.tabular.py is not importable as a Python module — the dot makes Python treat it as a subpackage lookup. Convert dots to underscores in both the codegen naming (naming.py) and runtime path lookups (path_util.py), with filesystem fallback in the reverse model→schema direction. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajcariaga16
approved these changes
Apr 21, 2026
ajcariaga16
approved these changes
Apr 21, 2026
nathan-stender
added a commit
that referenced
this pull request
Apr 21, 2026
### Fixed - Fall back to .tabular.schema.json in manifest lookup (#1190)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_schema_path_from_manifesthardcoded.schema.jsonsuffix, but LC REC/2023/03 and REC/2024/03 schemas are named.tabular.schema.jsonvalidate_asm_schema()to raiseFileNotFoundErrorwhen validating ASM JSON for those techniques.tabular.schema.jsonwhen.schema.jsondoesn't exist at the constructed pathTest plan
test_get_schema_path_from_manifest_tabular_fallbackverifies LC REC/2023/03 resolves correctly🤖 Generated with Claude Code