Skip to content

fix: Strip document-signature footer from Intelliflex v2.2 CSV#1193

Merged
nathan-stender merged 1 commit into
mainfrom
fix-intelliflex-v2-2-document-signature
Apr 22, 2026
Merged

fix: Strip document-signature footer from Intelliflex v2.2 CSV#1193
nathan-stender merged 1 commit into
mainfrom
fix-intelliflex-v2-2-document-signature

Conversation

@nathan-stender

Copy link
Copy Markdown
Collaborator

Summary

  • Real-world Intelliflex v2.2 CSV exports include a --DOCUMENT SIGNATURE-- footer block (serial number, data signature hashes) that was missing from the test fixture added in feat: Add Intelliflex v2.2 flat CSV format support #1184
  • These footer rows lack a WELL LOCATION value, creating duplicate NaN index entries in the parsed DataFrames. When Measurement.create looks up a location, df.loc[location] returns a DataFrame instead of a Series, causing pd.isna() to crash with "truth value of a Series is ambiguous"
  • Fix: strip footer lines starting at --DOCUMENT SIGNATURE-- before passing to read_csv, so pandas never sees them and dtype inference stays clean
  • Updated the v2.2 test CSV to include a representative document signature footer

Test plan

  • All 773 tests pass
  • Lint + mypy clean
  • Verified against real-world CO026755_P5_INTELLIFLEX (1).csv that previously crashed

🤖 Generated with Claude Code

… parsing

Real-world Intelliflex v2.2 exports include a --DOCUMENT SIGNATURE-- footer
block that was missing from the test fixture. These footer rows have no
WELL LOCATION, creating duplicate NaN index entries that cause pd.isna()
to fail with "truth value of a Series is ambiguous."

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nathan-stender
nathan-stender requested review from a team and slopez-b as code owners April 22, 2026 21:19
@nathan-stender
nathan-stender merged commit bb4ca0a into main Apr 22, 2026
9 checks passed
@nathan-stender
nathan-stender deleted the fix-intelliflex-v2-2-document-signature branch April 22, 2026 22:25
nathan-stender added a commit that referenced this pull request Apr 22, 2026
### Fixed

- Strip document-signature footer from Intelliflex v2.2 CSV (#1193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants