fix: Support bare UV curve name in Cytiva Unicorn parser#1200
Merged
Conversation
UNICORN 7.7 instruments with a single UV detector export the absorbance curve as just "UV" rather than "UV 1_280". The parser regex `^UV 1_\d+$` failed to match, raising "Unable to find curve data for absorbance measurement." Changes: - Update AbsorbanceMeasurement1 regex to `^UV( 1_\d+)?$` to match both "UV" and "UV 1_280" naming styles - Make all absorbance measurements optional (return None instead of raising) consistent with how other measurement types behave Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
approved these changes
May 18, 2026
nathan-stender
added a commit
that referenced
this pull request
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nonegracefully) instead of raising on missing curves — consistent with all other measurement typesContext
Files from UNICORN 7.7.0.4016 system failed with:
The file is a properly exported "Entire Result(s)" (has Result.xml, Chrom.1.Xml, SystemData, etc.) — it simply has a single UV detector whose curve is named "UV" without a wavelength suffix. The 30-file count (vs 40+) is because this system has fewer detector modules, not because it's a partial export.
Test plan
unicorn_1.ziptest passes unchanged (UV 1_280 format)unicorn_single_uv.ziptest covers bare "UV" curve name🤖 Generated with Claude Code