Skip to content

fix: Handle QuantStudio Stop Time and non-ASCII delta columns#1203

Merged
nathan-stender merged 1 commit into
mainfrom
fix/quantstudio-stop-time-and-delta-columns
May 20, 2026
Merged

fix: Handle QuantStudio Stop Time and non-ASCII delta columns#1203
nathan-stender merged 1 commit into
mainfrom
fix/quantstudio-stop-time-and-delta-columns

Conversation

@nathan-stender

Copy link
Copy Markdown
Collaborator

Summary

  • Accept "Experiment Run Stop Time" as alias for "Experiment Run End Time" in header metadata parsing (some QuantStudio exports use this alternate field name)
  • Explicitly read ΔΔCт - Fsigma and ΔΔCт + Fsigma columns with valid Python identifiers before get_unread(), preventing TypeError: Field names must be valid identifiers when these flow through make_dataclass()

Test plan

  • Added appbio_quantstudio_example10.xlsx test file exercising both fixes (384-well, Comparative Ct with "Stop Time" and ΔΔCт columns)
  • All 28 QuantStudio parser tests pass
  • All 312 vendor discovery tests pass
  • Lint clean

🤖 Generated with Claude Code

Accept "Experiment Run Stop Time" as alias for "Experiment Run End Time"
in the header metadata. Also explicitly read ΔΔCт columns with valid
Python identifiers to prevent make_dataclass() failures when get_unread()
passes them through.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nathan-stender
nathan-stender requested review from a team and slopez-b as code owners May 20, 2026 18:22
@nathan-stender
nathan-stender merged commit e3a432a into main May 20, 2026
9 checks passed
@nathan-stender
nathan-stender deleted the fix/quantstudio-stop-time-and-delta-columns branch May 20, 2026 18:59
nathan-stender added a commit that referenced this pull request May 21, 2026
### Fixed

- Support new PkN column format in Stunner parser (#1205)
- Recognize Evaluation-Kinetics sheet and SCK analyte lookup (#1204)
- Handle QuantStudio Stop Time and non-ASCII delta columns (#1203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants